Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add last run status to checks/rules #15838

Closed
desa opened this issue Nov 11, 2019 · 2 comments · Fixed by #16338
Closed

add last run status to checks/rules #15838

desa opened this issue Nov 11, 2019 · 2 comments · Fixed by #16338
Assignees

Comments

@desa
Copy link
Contributor

desa commented Nov 11, 2019

Similar to tasks, we should return

	LatestCompleted string                 `json:"latestCompleted,omitempty"`
	LatestScheduled time.Time              `json:"latestScheduled,omitempty"`
	LastRunStatus   string                 `json:"lastRunStatus,omitempty"`
	LastRunError    string                 `json:"lastRunError,omitempty"`

for checks and notification rules.

We should display something similar to the tasks UI.

Screenshot 2019-11-11 11 38 44

This will involved modifying the checks and notifications UI and API. In the API, we'll need to grab those values from the task that backs the check/rule.

@desa
Copy link
Contributor Author

desa commented Nov 11, 2019

Link #15844

@asalem1
Copy link
Contributor

asalem1 commented Dec 27, 2019

Currently blocked by changes made in the following PR:

#16333

It seems like the changes made to updateCheck weren’t updated here:

https://github.com/influxdata/influxdb/blob/master/ui/src/alerting/components/CheckCard.tsx#L17

Need some clarity from @ebb-tide on how to best go about update the component to accurately reflect the new functionality since the previous implementation seems to be a bit different on might require an overhaul of the way the check data is currently being updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment