fix(ui): Update numeric Input components to pass NaN where appropriat… #15797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCL735
force-pushed
the
fix_15024_delete_numeric_input
branch
2 times, most recently
from
2139610 to
b3f0dae
Compare
ghost
requested review from
asalem1 and
hoorayimhelping
and removed request for
a team
asalem1
reviewed
Nov 7, 2019
asalem1
reviewed
Nov 7, 2019
Good idea. I will attempt to write an e2e for this and will update status here. Edit: e2e tests will not be possible until a new version of clockface is released. We need version 1.0.5. Similarly, this PR should not be merged for the same reason, as without [email protected] there will be console errors. Edit 2: e2e tests are pushed now. |
TCL735
force-pushed
the
fix_15024_delete_numeric_input
branch
from
b3f0dae to
b9e528c
Compare
…e and fix other edge cases
TCL735
force-pushed
the
fix_15024_delete_numeric_input
branch
from
b9e528c to
6031a8a
Compare
hoorayimhelping
approved these changes
Nov 8, 2019
| }) | ||
| }) | ||
| }) | ||
|
|
| }) | ||
| }) | ||
| }) | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15024
Updates numeric Inputs to deliberately pass NaN when user input is completely deleted, as clockface will handle this appropriately, see influxdata/clockface#373
Fixes edge cases with bin sizes in Heat Maps and decimal places in Single Stat.