Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle NaN appropriately with value, type, and status #373

Merged
merged 1 commit into from
Nov 7, 2019
Merged

fix: handle NaN appropriately with value, type, and status #373

merged 1 commit into from
Nov 7, 2019

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Nov 6, 2019 •
edited
Loading

Closes influxdata/influxdb#15024

Changes

Updates numeric Input to handle NaN appropriately.

Checklist

  • Tests pass
  • Peer reviewed and approved

@TCL735 TCL735 requested a review from mavarius November 6, 2019 23:29
@alexpaxton
Copy link
Contributor

@TCL735 can you add an entry to the changelog?

mavarius
mavarius requested changes Nov 7, 2019
View reviewed changes
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, but otherwise looks good.

src/Components/Inputs/Documentation/Inputs.stories.tsx Outdated Show resolved Hide resolved
src/Components/Inputs/Documentation/Inputs.stories.tsx Outdated Show resolved Hide resolved
@TCL735 TCL735 mentioned this pull request Nov 7, 2019
Merged
@TCL735 TCL735 merged commit 360878b into master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavarius mavarius mavarius requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the user to delete all characters from numeric input
3 participants
@TCL735 @alexpaxton @mavarius