Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): alerting polish #14982

Merged
merged 15 commits into from
Sep 5, 2019
Merged

fix(ui): alerting polish #14982

merged 15 commits into from
Sep 5, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Sep 5, 2019 •
edited
Loading

Closes #14937
Closes #14941
Closes #14945
Closes #14947

Screen Shot 2019-09-05 at 2 38 18 PM

  • Add button in "first-time widget"
  • Make "first-time widget" darker to ensure contrast with button

endpoint-overlay-polish

  • Move type selection to the top of the form
  • Group type-dependent options in a panel
  • Add default values for URL for all types
  • Use Clockface Alert to display the error message
  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team September 5, 2019 21:44
@ghost ghost requested review from ebb-tide and removed request for a team September 5, 2019 21:44
@russorat
Copy link
Contributor

russorat commented Sep 5, 2019

remove content template from the http one
Name should be "Name this Endpoint"

@russorat
Copy link
Contributor

russorat commented Sep 5, 2019

http post should be the only option

russorat
russorat approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍧 🍧 🍧 🍧 🍧

@alexpaxton
Copy link
Contributor Author

Screen Shot 2019-09-05 at 2 49 46 PM
Screen Shot 2019-09-05 at 2 52 32 PM

@russorat russorat mentioned this pull request Sep 5, 2019
Closed
4 tasks
@alexpaxton
Copy link
Contributor Author

Screen Shot 2019-09-05 at 3 36 02 PM

Shrunk the message field to 90px

@alexpaxton
Copy link
Contributor Author

Screen Shot 2019-09-05 at 3 45 04 PM

Reversed the order of the thresholds here

@alexpaxton alexpaxton merged commit 0a3d580 into master Sep 5, 2019
@alexpaxton alexpaxton deleted the fix/alerting-polish branch September 5, 2019 23:19
@alexpaxton alexpaxton mentioned this pull request Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@121watts 121watts 121watts approved these changes

@russorat russorat russorat approved these changes

@ebb-tide ebb-tide Awaiting requested review from ebb-tide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alexpaxton @russorat @121watts