-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce DapperScrollbars #12961
Merged
Merged
Introduce DapperScrollbars #12961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chnn
reviewed
Mar 28, 2019
type Props = PassedProps & DefaultProps | ||
|
||
@ErrorHandling | ||
class DapperScrollbars extends Component<Props> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be PureComponent
?
AlirieGray
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@OfTheDelmer it would close #12989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12903
Closes #12630
Closes #12629
Closes #12989
Changes
Introduce
DapperScrollbars
wrapper forreact-scrollbars-custom
package as a replacement forFancyScrollbars
&react-custom-scrollbars
Implement
DapperScrollbars
in higher level components as well as areas that were problematic withFancyScrollbars
Style
DapperScrollbars
to mostly match the appearance ofFancyScrollbars
except for that the scrollbar track is slightly visible inDapperScrollbars
(useful for discerning which scroll component is being used at a glance).Preview
Gotchas
Tech Debt:
FancyScrollbars
withDapperScrollbars
so we're not supporting both)DapperScrollbars
are relying on!important
to override some of the inline styles injected by the libraryChecklist: