Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph legend items hidden in Firefox / can't scroll #12630

Closed
8 of 11 tasks
chnn opened this issue Mar 14, 2019 · 2 comments
Closed
8 of 11 tasks

Graph legend items hidden in Firefox / can't scroll #12630

chnn opened this issue Mar 14, 2019 · 2 comments
Assignees

Comments

@chnn
Copy link
Contributor

chnn commented Mar 14, 2019

Sometimes a few legend items will show, but the rest will be hidden out of view and not reachable by scrolling. In this case, the legend items didn't show up at all:

Screen Shot 2019-03-14 at 8 49 18 AM

  • explore the effectiveness of adding conditional styling in firefox for padding and scrollable lists
  • iterate on the react-custom-scrollbars to remove scrollbar styling and explore padding and other styling rules to always hide native scrollbars.

Horizontal / No Trackbar Width

  • Scrollable view does not need horizontal scrollbar
    • Solution: no need for margin-bottom
  • Scrollable view does need horizontal scrollbar and still scrolls vertically
    • Note: add negative margin-bottom but adding padding-bottom doesn’t really help

Horizontal / Scrollbar Trackbar Width

  • Overflow scroll always adds space for scrollbar
    • Solution: just add negative margin

Vertical / No Trackbar Width

  • Scroll view does need vert scrollbar
    • Solution: adding negative margin and padding should be fine
  • Scroll view does not need vert scrollbar and still scrolls horizontally
    • Note: needs verification that negative margin-right and adding padding-right solves this

Vertical / With Trackbar Width

  • Overflow scroll always adds space for scrollbar
    • Solution: just add negative margin

  • add Chrome scrollbar width/height styling when calling getScrollbarWidth() to remove check for isFirefox. This means Chrome never allocates space for a scrollbar.
  • update initial rendering to always apply negative margins
  • update initial rendering to only apply padding or some kind scroll spacing when getScrollbarWidth() is zero.
@chnn chnn changed the title Graph legend items hidden in Firefox Graph legend items hidden in Firefox / can't scroll Mar 14, 2019
@OfTheDelmer OfTheDelmer self-assigned this Mar 20, 2019
@OfTheDelmer
Copy link
Contributor

To reproduce in Firefox

  • Have a mouse plugged then the legend looks fine
  • Unplug mouse and trackpad over graph... legend collapses and hides contents

Kapture 2019-03-21 at 13 05 46

@OfTheDelmer
Copy link
Contributor

@alexpaxton I think this is a fancy scrollbars firefox issue relating to mouse vs trackpad on mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants