Allow connecting to influxdb running on a path on the server

[gladhorn]

Make it possible to connect to the databases on a path on servers.
https://someserver.com/myinfluxdb instead of the root of the server.

[gladhorn]

As far as I can tell the failures in the tests are unrelated in this change and also visible in other merge requests.

[gladhorn]

Is anyone looking at these requests? And is there some way to re-run travis?

[xginn8]

sorry about the delay -- looking into CI failures.

[gladhorn]

Thanks :)

[xginn8]

Since you're slicing the string here, perhaps it would make sense to first cast the input to a string (similar to the above port cast)?

[gladhorn]

So you'e prefer something like:

_path = str(path)
self.__path = _path if not _path or _path[0] == '/' else '/' + _path

Any other suggestion how to make this look better?

[aviau]

It dosen't have to be a oneliner

[gladhorn]

Sure, my suggestion was no longer a one-liner either. What should it be like?

[micw]

Any chance to get this reviewed soon? I stumbled across this issue in HomeAssistant which uses the library and I'd like to create a patch for it - but that needs this feature released ;)

Kind regards,
Michael.

[micw]

IMO it should also handle (and test) if path is None.

[micw]

I'd create another PR with path=None test.

[gladhorn]

path=None is tested in the test already, it's the default case. The newly added tests test the other cases.

[micw]

I beg to differ. The default is an empty string which actually works. Just added a test with None path:

        cli = InfluxDBClient(
            'host', 8086, 'username', 'password', 'database', ssl=True,
            path=None     
        )
        self.assertEqual('https://host:8086', cli._baseurl)

The test fails:

AssertionError: u'https://host:8086' != u'https://host:8086None'
- https://host:8086
+ https://host:8086None
?                  ++++

I have created a PR to your PR that adds the test and the fix (I split the expression since 3 conditions don't fit into one line anymore).

[sthenault]

LGTM

[sthenault]

would be interested in this PR too

[xginn8]

Thanks for your contribution!

[gladhorn]

Thanks for taking it in :) less ugly workarounds on my side.