fix: Don't report an error about testcases in the LSP #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 20, 2022 14:41
We should only need to care about this when actually serializing to flatbuffer, so just make that error instead of panicking
Marwes
force-pushed
the
allow_testcase_in_lsp
branch
from
d8d30de
to
8e85b70
Compare
added 2 commits
September 20, 2022 14:44
We didn't hit this code path before as testcases never passed through it but now that testcases can (with the LSP) we need to handle it correctly.
Marwes
force-pushed
the
allow_testcase_in_lsp
branch
from
8e85b70
to
5d0d63e
Compare
|
ping @jsternberg |
jsternberg
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only need to care about testcases when actually serializing to flatbuffer, so just make that error instead of panicking and remove the pre-check.
Fixes influxdata/flux-lsp#403 (again? the LSP seems to run semantic checks now which is why it was reintroced/is still reporting this error)
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.