-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestCase is not supported in semantic analysis #403
Closed
onelson opened this issue
Feb 16, 2022
· 2 comments
· Fixed by influxdata/flux#4566 or influxdata/flux#5086
Closed
TestCase is not supported in semantic analysis #403
onelson opened this issue
Feb 16, 2022
· 2 comments
· Fixed by influxdata/flux#4566 or influxdata/flux#5086
Comments
I get this too, in short the test harness rewrites |
nathanielc
added a commit
to influxdata/flux
that referenced
this issue
Mar 16, 2022
Now the AST -> Semantic convert step does not error on testcase statements, rather an explicit semantic check is used to catch remaining testcase statements. The TestCase semantic node behaves like a partial file where it has a statement list instead of a block. A block is an expression that evaluates to a value which is not appropriate for a testcase. Fixes influxdata/flux-lsp#403 because the LSP already skips semantic checks and so it doesn't report a diagnostic about a testcase statement.
2 tasks
nathanielc
added a commit
to influxdata/flux
that referenced
this issue
Mar 16, 2022
Now the AST -> Semantic convert step does not error on testcase statements, rather an explicit semantic check is used to catch remaining testcase statements. The TestCase semantic node behaves like a partial file where it has a statement list instead of a block. A block is an expression that evaluates to a value which is not appropriate for a testcase. Fixes influxdata/flux-lsp#403 because the LSP already skips semantic checks and so it doesn't report a diagnostic about a testcase statement.
nathanielc
added a commit
to influxdata/flux
that referenced
this issue
Mar 16, 2022
Now the AST -> Semantic convert step does not error on testcase statements, rather an explicit semantic check is used to catch remaining testcase statements. The TestCase semantic node behaves like a partial file where it has a statement list instead of a block. A block is an expression that evaluates to a value which is not appropriate for a testcase. Fixes influxdata/flux-lsp#403 because the LSP already skips semantic checks and so it doesn't report a diagnostic about a testcase statement.
nathanielc
added a commit
to influxdata/flux
that referenced
this issue
Mar 17, 2022
…4566) Now the AST -> Semantic convert step does not error on testcase statements, rather an explicit semantic check is used to catch remaining testcase statements. The TestCase semantic node behaves like a partial file where it has a statement list instead of a block. A block is an expression that evaluates to a value which is not appropriate for a testcase. Fixes influxdata/flux-lsp#403 because the LSP already skips semantic checks and so it doesn't report a diagnostic about a testcase statement.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using the CLI lang server with IntelliJ, testcases are rendered as errors.
For this instance, I was looking at
stdlib/array/array_test.flux
in the flux repo.Here's the log output from the lang server:
The text was updated successfully, but these errors were encountered: