Enable toggling display issues as warnings or errors #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dehall
force-pushed
the
toggle_display_warnings
branch
from
1552674
to
9ff7667
Compare
dehall
commented
Jul 12, 2023
| @@ -64,7 +77,7 @@ public Validator(String igDir) throws Exception { | |||
| // The two lines below turn off URL resolution checking in the validator. | |||
| // This eliminates the need to silence these errors elsewhere in Inferno | |||
| // And also keeps contained resources from failing validation based solely on URL errors | |||
| ValidationControl vc = new BaseValidator(null, null) | |||
| ValidationControl vc = new BaseValidator(null, null, false) | |||
There was a problem hiding this comment.
dehall
changed the title
|
We'll have to make g10 updates to deal with these errors:
|
|
@Jammjammjamm Yes apologies I forgot to link the associated g10 PR -- that change is made here: onc-healthit/onc-certification-g10-test-kit#449 |
dehall
force-pushed
the
toggle_display_warnings
branch
from
9ff7667
to
2616d56
Compare
Jammjammjamm
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses FI-1994 and FI-1995
This PR bumps the HL7 validator dependency to 6.0.21 so that we can toggle whether code display errors from the terminology server are reported as warnings or errors. This also checks for a new environment variable
DISPLAY_ISSUES_ARE_WARNINGSto toggle it on and off per instance. (Unfortunately it's a setting on the validator instance not a parameter of the validate function, so given the current architecture we can't easily toggle it per-request.) The env var was chosen to match the setting name used on the official validator CLI. The default matches the default of the official validator, where code display issues are errors.Note 1: this PR is marked as WIP while I continue to test it out to ensure nothing breaks elsewhereNote 2: I pushed the 2 changes here to separate branches so that if we want to start with just the bumped dependency version we can do that -- see branch
bump_hl7_validatorNote 3: CI is still failing, see #60 to resolve that
Testing Guidance
I have two minimal sample resources to test with in src/test/resources
DISPLAY_ISSUES_ARE_WARNINGS=trueand validating resources. Resources with a display issue should return warnings. Resources without issues should still be fine