Fix failing test due to mCODE profile names changing #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just a quick update to one of the unit tests so that it passes. mCODE 3.0.0-ballot has been released recently, and one of the changes from v2 to v3 is renaming the "Comorbidities Parent" profile to just "Comorbidities". Fetching an IG without a specific version will get the "current", so it's now fetching 3.0.0.
I removed that one assertion that checks that the "comorbidities-parent" profile was loaded so the test now passes.
I could have added more assertions but since it's already only checking a subset I figured this is good enough.
I also noticed the tests were failing on CI without a useful error message, which I suspect was due to out of memory errors. I set heap memory available for tests to 6 GB since that seemed to be enough to make it pass locally. (Also the same size we set for Synthea)
I also updated the JUnit dependency to make unit tests work in Eclipse. There should be no other noticeable impact from that change.
Testing Guidance
./gradlew test- all tests should pass, locally and on CI