FI-946: Add a way to load a package.tgz into the validator app #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radamson
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Code generally looks good and it worked when testing it out.
I did notice that if I upload a standalone profile and select a standalone profile it will validate against both. I think that's ok for now, but its a bit...surprising. Something to discuss and perhaps change in a future PR and this still works as is.
Also I see a few React warnings that we should address in a future PR (Created FI-960 to address this)
Those warnings are caused by react-select, unfortunately :( But yes, we should keep an eye out for that fix |
…ceCard, and AdvancedOptionsCard 2. Remove generics from FormInputItem
jason-crowley
force-pushed
the
load-package-tgz
branch
from
1a0fd91 to
493fe1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FI-946: This PR adds a way for users to load custom IGs into the validator by uploading a
package.tgzfile. It requires the fixes in fhir-validator-wrapper#21 to work correctly.