Warnings: componentWillReceiveProps in strict mode, Legacy context API, findDOMNode is deprecated

[bladey]

This issue is a round-up of multiple past issues documenting the same bug. Feel free to check out the linked issues below for more information. This issue is the source of truth going forward to investigate the issue, report findings, and implement a bug fix.

Issue:

Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://fb.me/react-unsafe-component-lifecycles for details.

Warning: Legacy context API has been detected within a strict-mode tree.

The old API will be supported in all 16.x releases, but applications using it should migrate to the new version.

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of NodeResolver which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node

Issues:

#3751
#3720
#3915
#3745
#4068
#3703

If anyone would like to share any further information, please do so.

[manvydasu]

So basically someone would have to create a PR and replace legacy component lifecycle methods with newer version: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#migrating-from-legacy-lifecycles

However, looking at usages and code inside of UNSAFE_componentWillReceiveProps , it might not be so straightforward.

[corysimmons]

For anyone else going insane over this, you can disable those warnings (and other, actually helpful ones) by commenting out <React.StrictMode> in index.js. Just remember to uncomment it a few times a day to get the helpful warnings.

---

Update: Stop confused-face'ing me you monsters! 😭

[OlegPuzankin]

Can anyone say - are these warnings critical and can we expect the developers to fix that in the future?

[corysimmons]

@OlegPuzankin They aren't critical in React 16.x.x, in React 17+ I suspect all the deprecated UNSAFE_xyz methods will be removed so any libraries depending on those methods will stop working.

Yes, the maintainer is aware of it and has it on their todo list.

[BraveEvidence]

React v17 has been released. Someone please fix this issue

[ljharb]

The UNSAFE removal has been deferred to React 18.

[Methuselah96]

I've started a fork of react-select. Feel free to resubmit this issue on the fork and/or submit a PR to resolve this issue on the fork and we can get it merged and released.

EDIT: 🎉 I've archived the fork now that we've got some momentum in this repo and Jed is involved again. Sorry for the disturbance!

[corysimmons]

@Methuselah96 Is that a drop-in replacement that won't spam the UNSAFE warnings?

Edit: Seems to have the same UNSAFE warnings and others are submitting PRs to that project... so... why not just PR this project instead? 🤔

[Methuselah96]

@corysimmons I haven't finished the changes necessary to remove the UNSAFE warnings in the fork.

I didn't make a PR for this project, because at the time, it had been several months since any PR had been merged and half a year since a new version had been released. I planned on creating a PR once I had finished all the changes necessary.

As long as this project is actually maintained, I'll make PRs here and hopefully archive my fork.

EDIT: I've made a PR: #4313.

[bwilson]

Thanks for your efforts!

…

On Wed, Nov 25, 2020 at 2:33 PM Nathan Bierema ***@***.***> wrote: @corysimmons <https://github.com/corysimmons> I haven't finished the changes necessary to remove the UNSAFE warnings in the fork. I didn't make a PR for this project, because at the time, it had been several months since any PR had been merged and half a year since a new version had been released. I planned on creating a PR once I had finished all the changes necessary. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4094 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYL5RGUSQDUWO7JONCTCTSRVSX3ANCNFSM4OBIGG7Q> .

[flora8984461]

Have the same issue here.

[Dezzymei]

I am still getting this issue. I thought this was working with react 17?

[corysimmons]

@Methuselah96 Thank you, Hero!

[Ochaun]

Still getting this issue on 4.1.0 for the Animated Select.

[ebonow]

@Ochaun this is being tracked in #4456