Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5135 - Cannot jump to curation suggestion without accepting it #5137

Conversation

reckart
Copy link
Member

@reckart reckart commented Nov 5, 2024

What's in the PR

  • Change the scrollTo JS API function to accept multiple offsets (although only the first one is currently ever used)
  • Fix ScrollToHandler to jump without taking the window offset into consideration
  • Fix the annotation sidebar to properly jump

How to test manually

  • See issue

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Change the scrollTo JS API function to accept multiple offsets (although only the first one is currently ever used)
- Fix ScrollToHandler to jump without taking the window offset into consideration
- Fix the annotation sidebar to properly jump
@reckart reckart added 🐛Bug Something isn't working Module: Curation labels Nov 5, 2024
@reckart reckart added this to the 34.3 milestone Nov 5, 2024
@reckart reckart self-assigned this Nov 5, 2024
@reckart reckart merged commit 07a5b26 into release/34.x Nov 5, 2024
2 of 3 checks passed
@reckart reckart deleted the bugfix/5135-Cannot-jump-to-curation-suggestion-without-accepting-it branch November 5, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Curation
Projects
Status: 🍹 Done
Development

Successfully merging this pull request may close these issues.

1 participant