Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot jump to curation suggestion without accepting it #5135

Closed
reckart opened this issue Nov 4, 2024 · 0 comments
Closed

Cannot jump to curation suggestion without accepting it #5135

reckart opened this issue Nov 4, 2024 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Curation
Milestone
34.3

Comments

@reckart
Copy link
Member

reckart commented Nov 4, 2024

Describe the bug
It should be possible to jump to a curation suggestion via the annotation sidebar without accepting it.

To Reproduce
Steps to reproduce the behavior:

  1. Open the annotation sidebar on the integrated curation page
  2. Click on the text of an curation suggestion (not on the label badge)
  3. See the suggestion is accepted

Expected behavior
Instead of accepting, the view should just jump there.

Please complete the following information:

  • Version and build ID: 34.2
@reckart reckart added 🐛Bug Something isn't working Module: Curation labels Nov 4, 2024
@reckart reckart added this to the 34.3 milestone Nov 4, 2024
@reckart reckart self-assigned this Nov 4, 2024
@reckart reckart added this to Kanban Nov 4, 2024
@github-project-automation github-project-automation bot moved this to 🔖 To do in Kanban Nov 4, 2024
@reckart reckart changed the title Jump to curation suggestion without accepting it Cannot jump to curation suggestion without accepting it Nov 4, 2024
reckart added a commit that referenced this issue Nov 4, 2024
@reckart
#5135 - Cannot jump to curation suggestion without accepting it
91cffb4 
- Change the scrollTo JS API function to accept multiple offsets (although only the first one is currently ever used)
- Fix ScrollToHandler to jump without taking the window offset into consideration
- Fix the annotation sidebar to properly jump
reckart added a commit that referenced this issue Nov 5, 2024
@reckart
Merge pull request #5136 from inception-project/bugfix/5135-Cannot-ju…
2a4df95 
…mp-to-curation-suggestion-without-accepting-it

#5135 - Cannot jump to curation suggestion without accepting it
@reckart reckart closed this as completed Nov 5, 2024
@github-project-automation github-project-automation bot moved this from 🔖 To do to 🍹 Done in Kanban Nov 5, 2024
reckart added a commit that referenced this issue Nov 5, 2024
@reckart
#5135 - Cannot jump to curation suggestion without accepting it
5fbe17b 
- Change the scrollTo JS API function to accept multiple offsets (although only the first one is currently ever used)
- Fix ScrollToHandler to jump without taking the window offset into consideration
- Fix the annotation sidebar to properly jump
reckart added a commit that referenced this issue Nov 5, 2024
@reckart
Merge pull request #5137 from inception-project/bugfix/5135-Cannot-ju…
07a5b26 
…mp-to-curation-suggestion-without-accepting-it

#5135 - Cannot jump to curation suggestion without accepting it
reckart added a commit that referenced this issue Nov 5, 2024
@reckart
Merge branch 'release/34.x'
86c4579 
* release/34.x:
  No issue: Remove dependency analysis - it just takes forever and does not seem to finish
  No issue: Run dependency analysis only on push to avoid making the PRs build longer
  No issue: Try re-enabling the dependency submission and attach build artifacts
  #5127 - Enable score on curation suggestions by default
  #5135 - Cannot jump to curation suggestion without accepting it
  #5135 - Cannot jump to curation suggestion without accepting it
  #5133 - Add keybindings to named entity template sample data
  #5133 - Add keybindings to named entity template sample data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Curation
Projects
Kanban
Status: 🍹 Done
Milestone
34.3
Development

No branches or pull requests
1 participant
@reckart