Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4994 - Annotation browser sometimes does not load in sidebar curation mode #5005

Conversation

reckart
Copy link
Member

@reckart reckart commented Aug 20, 2024

What's in the PR

  • Make browser component more robust to even render if arc targets are missing (ignoring those arcs)
  • Improve curation sidebar renderer to handle cases where a link source is hidden due to an already merged annotation
  • Add hashCode and equals to Positions because it also implements compareTo

How to test manually

  • Try sidebar curation mode

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

…n mode

- Make browser component more robust to even render if arc targets are missing (ignoring those arcs)
- Improve curation sidebar renderer to handle cases where a link source is hidden due to an already merged annotation
- Add hashCode and equals to Positions because it also implements compareTo
@reckart reckart added 🐛Bug Something isn't working Module: Curation labels Aug 20, 2024
@reckart reckart added this to the 33.5 milestone Aug 20, 2024
@reckart reckart self-assigned this Aug 20, 2024
@reckart reckart merged commit d3f3ad8 into release/33.x Aug 20, 2024
3 checks passed
@reckart reckart deleted the bugfix/4994-Annotation-browser-sometimes-does-not-load-in-sidebar-curation-mode branch August 20, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Curation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant