Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation browser sometimes does not load in sidebar curation mode #4994

Closed
s2fische opened this issue Aug 16, 2024 · 3 comments
Closed

Annotation browser sometimes does not load in sidebar curation mode #4994

s2fische opened this issue Aug 16, 2024 · 3 comments
Assignees
Labels
🐛 Bug Something isn't working Module: Annotation
Milestone

Comments

@s2fische
Copy link

For a number of already annotated and curated documents, the list of annotations (selectable in left-hand side bar) does not load, even after several minutes of waiting, when opening them as a curator in annotation mode. This happens whether the curation is still in progress or not. All documents from our project except for three (one of which has not been annotated yet) are affected.

Screenshot 2024-08-16 105027

How it should look:

Screenshot 2024-08-16 111831

Please complete the following information:

  • Version and build ID: INCEpTION -- 33.3 (2024-07-23 20:06:53, build d72b69e)
  • OS: Windows 11
  • Browser: Chrome
@reckart
Copy link
Member

reckart commented Aug 18, 2024

Could you please open the javascript developer console in your browser and check in the console log if you see any error(s) there?

@reckart
Copy link
Member

reckart commented Aug 20, 2024

I think I can reproduce it.

AnnotationsByLabelList.svelte:211 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'offsets')
    at AnnotationsByLabelList.svelte:211:82
    at Array.sort (<anonymous>)
    at r.$$.update (AnnotationsByLabelList.svelte:211:82)
    at ks (scheduler.js:115:6)
    at At (scheduler.js:79:5)

@reckart reckart added this to Kanban Aug 20, 2024
@github-project-automation github-project-automation bot moved this to 🔖 To do in Kanban Aug 20, 2024
@reckart reckart added this to the 33.5 milestone Aug 20, 2024
@reckart
Copy link
Member

reckart commented Aug 20, 2024

I suspect the problem occurs when a relation/link endpoint from a curator is hidden because an annotation at this point has already been merged. Probably in this case, a relation/link may still be rendered using the annotator-annotation as the endpoint instead of the curated annotation.

@reckart reckart changed the title Annotations list doesn't load Annotation browser sometimes does not load in sidebar curation mode Aug 20, 2024
reckart added a commit that referenced this issue Aug 20, 2024
…n mode

- Make browser component more robust to even render if arc targets are missing (ignoring those arcs)
- Improve curation sidebar renderer to handle cases where a link source is hidden due to an already merged annotation
- Add hashCode and equals to Positions because it also implements compareTo
reckart added a commit that referenced this issue Aug 20, 2024
…n-browser-sometimes-does-not-load-in-sidebar-curation-mode

#4994 - Annotation browser sometimes does not load in sidebar curation mode
@reckart reckart closed this as completed Aug 20, 2024
@github-project-automation github-project-automation bot moved this from 🔖 To do to 🍹 Done in Kanban Aug 20, 2024
reckart added a commit that referenced this issue Aug 20, 2024
* release/33.x:
  #4994 - Annotation browser sometimes does not load in sidebar curation mode

% Conflicts:
%	inception/inception-curation-legacy/src/main/java/de/tudarmstadt/ukp/clarin/webanno/curation/casdiff/api/Position_ImplBase.java
%	inception/inception-curation-legacy/src/main/java/de/tudarmstadt/ukp/clarin/webanno/curation/casdiff/relation/RelationPosition.java
%	inception/inception-curation-legacy/src/main/java/de/tudarmstadt/ukp/clarin/webanno/curation/casdiff/span/SpanPosition.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working Module: Annotation
Projects
Archived in project
Development

No branches or pull requests

2 participants