Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4839 - Scrolling to selection does sometimes not work in Apache Annotator Editor #4840

Conversation

reckart
Copy link
Member

@reckart reckart commented May 31, 2024

What's in the PR

  • Normalize DOM after removing markers because Apache Annotator can fail to create marker annotations in a fragemented DOM

How to test manually

  • Requires an affected document

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 32.4 milestone May 31, 2024
@reckart reckart self-assigned this May 31, 2024
…tator Editor

- Normalize DOM after removing markers because Apache Annotator can fail to create marker annotations in a fragemented DOM
@reckart reckart force-pushed the bugfix/4839-Scrolling-to-selection-does-sometimes-not-work-in-Apache-Annotator-Editor branch from 1a196ec to 8c2e1c4 Compare May 31, 2024 18:09
@reckart reckart merged commit 26d1d1a into release/32.x May 31, 2024
3 checks passed
@reckart reckart deleted the bugfix/4839-Scrolling-to-selection-does-sometimes-not-work-in-Apache-Annotator-Editor branch May 31, 2024 18:59
@reckart reckart modified the milestones: 32.4, 33.0 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant