Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4557 - Bulk process page should not show processes from other projects #4609

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 9, 2024

What's in the PR

  • Distinguish between ProjectTask and other tasks using marker interface
  • Route user tasks and project tasks separately in SchedulerWebsockerControllerImpl
  • Allow TaskMonitoringPanel to be configured more flexibly for the the Websocket topics it uses
  • Moved logging UI code out to a new module
  • Bit of cleaning up here and there

How to test manually

  • Try running bulk processing jobs from different projects and users and see if they appear in the other projects/users

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

reckart added 2 commits March 9, 2024 07:58
- Distinguish between ProjectTask and other tasks using marker interface
- Route user tasks and project tasks separately in SchedulerWebsockerControllerImpl
- Allow TaskMonitoringPanel to be configured more flexibly for the the Websocket topics it uses
- Moved logging UI code out to a new module
- Bit of cleaning up here and there
@reckart reckart added this to the 32.0 milestone Mar 9, 2024
@reckart reckart self-assigned this Mar 9, 2024
@reckart reckart force-pushed the bugfix/4557-Bulk-process-page-should-not-show-processes-from-other-projects branch 9 times, most recently from 24233b2 to 0ced2c7 Compare March 9, 2024 17:34
- After enabling method security, remove pointles preauthorize annotations
- Use a TempDir for a test
- Shut down KB after test method
- Try making PDF text extraction tests work on Windows
- Use in-memory DB for an integration test so we don't have issues with deleting DB files after shutdown on Windows
- Try shutting down log4j after test so the temporary folder can be deleted in the end on Windwos
@reckart reckart force-pushed the bugfix/4557-Bulk-process-page-should-not-show-processes-from-other-projects branch from 0ced2c7 to 667a38b Compare March 9, 2024 18:00
@reckart reckart merged commit 1a58b2c into main Mar 9, 2024
3 checks passed
@reckart reckart deleted the bugfix/4557-Bulk-process-page-should-not-show-processes-from-other-projects branch March 9, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant