Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4289 - Ability to skip SSL certificate validation on external recommenders #4290

Conversation

reckart
Copy link
Member

@reckart reckart commented Nov 10, 2023

What's in the PR

  • Added checkbox in external recommender settings that can be used to disable certificate checks

How to test manually

  • Set up an external recommender and point it to https://expired.badssl.com/
  • With certificate checks enabled, it should fail with a PKIX exception
  • Without certificate checks it should fail with a 404

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

…enders

- Added checkbox in external recommender settings that can be used to disable certificate checks
@reckart reckart added this to the 30.0 milestone Nov 10, 2023
@reckart reckart self-assigned this Nov 10, 2023
@reckart reckart merged commit 7fa1ec5 into release/29.x Nov 14, 2023
1 check passed
@reckart reckart deleted the feature/4289-Ability-to-skip-SSL-certificate-validation-on-external-recommenders branch November 14, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant