Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to skip SSL certificate validation on external recommenders #4289

Closed
reckart opened this issue Nov 10, 2023 · 0 comments
Closed

Ability to skip SSL certificate validation on external recommenders #4289

reckart opened this issue Nov 10, 2023 · 0 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request Module: Recommender
Milestone
29.9

Comments

@reckart
Copy link
Member

reckart commented Nov 10, 2023

Is your feature request related to a problem? Please describe.
When deploying an external recommender using a self-signed SSL certificate, the connection fails.

Describe the solution you'd like
For testing at least, it would be nice if the SSL check could be disabled.

Describe alternatives you've considered
For actual use of course, properly installing the self-signed certificate into the Java certificate store would be better.
@reckart reckart added this to the 30.0 milestone Nov 10, 2023
@reckart reckart self-assigned this Nov 10, 2023
reckart added a commit that referenced this issue Nov 10, 2023
@reckart
#4289 - Ability to skip SSL certificate validation on external recomm…
01bbec3 
…enders

- Added checkbox in external recommender settings that can be used to disable certificate checks
reckart added a commit that referenced this issue Nov 14, 2023
@reckart
Merge pull request #4290 from inception-project/feature/4289-Ability-…
7fa1ec5 
…to-skip-SSL-certificate-validation-on-external-recommenders

#4289 - Ability to skip SSL certificate validation on external recommenders
reckart added a commit that referenced this issue Nov 14, 2023
@reckart
Merge branch 'release/29.x'
3bd1a8c 
* release/29.x:
  #4289 - Ability to skip SSL certificate validation on external recommenders

% Conflicts:
%	inception/inception-imls-external/src/main/java/de/tudarmstadt/ukp/inception/recommendation/imls/external/v1/ExternalRecommender.java
reckart added a commit that referenced this issue Nov 14, 2023
@reckart
Merge branch 'main' into feature/4292-ollama-based-recommender
444e235 
* main:
  #4294 - Infer paragraph boundaries when displaying plain text files in HTML-based editors
  #4289 - Ability to skip SSL certificate validation on external recommenders
@reckart reckart closed this as completed Nov 17, 2023
reckart added a commit that referenced this issue Nov 21, 2023
@reckart
#4289 - Ability to skip SSL certificate validation on external recomm…
69a10fc 
…enders

- Added tests
- Disabling certificate checks for WebHooks also disables host name checking
- Can currently not disable host name checking when using the Java 11 HTTP client
reckart added a commit that referenced this issue Nov 21, 2023
@reckart
#4289 - Ability to skip SSL certificate validation on external recomm…
ce9ee8c 
…enders

- Improve documentation
reckart added a commit that referenced this issue Nov 21, 2023
@reckart
#4289 - Ability to skip SSL certificate validation on external recomm…
df2554f 
…enders

- Improve documentation
@reckart reckart reopened this Nov 22, 2023
reckart added a commit that referenced this issue Nov 22, 2023
@reckart
Merge pull request #4318 from inception-project/feature/4289-Ability-…
b7aca06 
…to-skip-SSL-certificate-validation-on-external-recommenders

#4289 -  Ability to skip SSL certificate validation on external recommenders
@reckart reckart modified the milestones: 30.0, 29.9 Nov 22, 2023
reckart added a commit that referenced this issue Nov 22, 2023
@reckart
Merge branch 'release/29.x'
3a57f1c 
* release/29.x:
  #4289 -  Ability to skip SSL certificate validation on external recommenders
  #4289 -  Ability to skip SSL certificate validation on external recommenders
reckart added a commit that referenced this issue Nov 22, 2023
@reckart
Merge branch 'main' into feature/4292-ollama-based-recommender
0b3900e 
* main:
  #4229 - Better project template selection
  #4289 -  Ability to skip SSL certificate validation on external recommenders
  #4289 -  Ability to skip SSL certificate validation on external recommenders
@reckart reckart closed this as completed Nov 22, 2023
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Recommender
Projects
Kanban
Archived in project
Milestone
29.9
Development

No branches or pull requests
1 participant
@reckart