Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3623 - Migrate the recommender event notifier from vue to svelte #3624

Merged
merged 4 commits into from
Dec 10, 2022
Merged

#3623 - Migrate the recommender event notifier from vue to svelte #3624

merged 4 commits into from
Dec 10, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Dec 9, 2022

What's in the PR

  • Migrate the JS code from vue to svelte
  • Add access control layer to the websocket endpoint for recommender events including unit test
  • Make recommender notifications less frequent and more convenient for the end user
  • Exclude recommender notification events from the event log (and a few other low-utility events)
  • Rebuild package-lock.json
  • Try improving destruction of svelte components when they are redrawn by wicket
  • Self-destroy recommender notification svelte and annottion sidebar svelte component if they get a message and discover they are no longer visible anyway - this should avoid redundant subscriptions on the server side and the server sending too much data

How to test manually

  • Enable recommender notifications via websocket and try them out
  • Use the annotation sidebar (for good measure)

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#3623 - Migrate the recommender event notifier from vue to svelte
865d539 
- Migrate the JS code from vue to svelte
- Add access control layer to the websocket endpoint for recommender events including unit test
- Make recommender notifications less frequent and more convenient for the end user
- Exclude recommender notification events from the event log (and a few other low-utility events)
- Rebuild package-lock.json
- Try improving destruction of svelte components when they are redrawn by wicket
- Self-destroy recommender notification svelte and annottion sidebar svelte component if they get a message and discover they are no longer visible anyway - this should avoid redundant subscriptions on the server side and the server sending too much data
@reckart reckart added this to the 27.0 milestone Dec 9, 2022
@reckart reckart self-assigned this Dec 9, 2022
@reckart reckart merged commit cfe210b into main Dec 10, 2022
@reckart reckart deleted the refactoring/3623-Migrate-the-recommender-event-notifier-from-vue-to-svelte branch December 10, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⚙️ Refactoring
Projects
Kanban
Archived in project
Milestone
27.0
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart