Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the recommender event notifier from vue to svelte #3623

Closed
reckart opened this issue Dec 9, 2022 · 0 comments
Closed

Migrate the recommender event notifier from vue to svelte #3623

reckart opened this issue Dec 9, 2022 · 0 comments

Comments

@reckart
Copy link
Member

reckart commented Dec 9, 2022

Describe the refactoring action
Migrate the recommender event notifier from vue to svelte.

Expected benefit
Remove vue from the codebase. It has a much too large dependency footprint.

@reckart reckart added this to the 27.0 milestone Dec 9, 2022
@reckart reckart self-assigned this Dec 9, 2022
reckart added a commit that referenced this issue Dec 9, 2022
- Migrate the JS code from vue to svelte
- Add access control layer to the websocket endpoint for recommender events including unit test
- Make recommender notifications less frequent and more convenient for the end user
- Exclude recommender notification events from the event log (and a few other low-utility events)
- Rebuild package-lock.json
- Try improving destruction of svelte components when they are redrawn by wicket
- Self-destroy recommender notification svelte and annottion sidebar svelte component if they get a message and discover they are no longer visible anyway - this should avoid redundant subscriptions on the server side and the server sending too much data
reckart added a commit that referenced this issue Dec 9, 2022
reckart added a commit that referenced this issue Dec 10, 2022
reckart added a commit that referenced this issue Dec 10, 2022
reckart added a commit that referenced this issue Dec 10, 2022
…ate-the-recommender-event-notifier-from-vue-to-svelte

#3623 - Migrate the recommender event notifier from vue to svelte
@reckart reckart closed this as completed Dec 10, 2022
reckart added a commit that referenced this issue Dec 11, 2022
* main:
  #3625 - Remove DiamDebugEditor
  #3625 - Remove DiamDebugEditor
  #3625 - Remove DiamDebugEditor
  #3625 - Remove DiamDebugEditor
  #3623 - Migrate the recommender event notifier from vue to svelte
  #3623 - Migrate the recommender event notifier from vue to svelte
  #3623 - Migrate the recommender event notifier from vue to svelte
  #3623 - Migrate the recommender event notifier from vue to svelte
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant