Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearing hidden feature does sometimes not work #4942

Closed
reckart opened this issue Jul 14, 2024 · 0 comments
Closed

Clearing hidden feature does sometimes not work #4942

reckart opened this issue Jul 14, 2024 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Constraints
Milestone
33.3

Comments

@reckart
Copy link
Member

reckart commented Jul 14, 2024

Describe the bug
If there are multiple rules using the same feature in the condition and affecting a conditional feature in the restrictions, then the conditional feature may not be cleared when hidden.

Expected behavior
Conditional features that are not visible should be cleared and not be considered for validation.

Please complete the following information:

  • Version and build ID: 33.2
@reckart reckart added 🐛Bug Something isn't working Module: Constraints labels Jul 14, 2024
@reckart reckart added this to the 33.3 milestone Jul 14, 2024
@reckart reckart self-assigned this Jul 14, 2024
reckart added a commit that referenced this issue Jul 14, 2024
@reckart
#4942 - Clearing hidden feature does sometimes not work
6d6efbb 
- Cleaning up code
- Fixed issue
- Added more unit tests
@reckart reckart closed this as completed Jul 14, 2024
reckart added a commit that referenced this issue Jul 16, 2024
@reckart
Merge branch 'release/33.x'
f273e04 
* release/33.x:
  #4940 - OAuth and SAML logins do not work if a servlet path is used
  #4942 - Clearing hidden feature does sometimes not work

% Conflicts:
%	inception/inception-security/src/main/java/de/tudarmstadt/ukp/clarin/webanno/security/config/SecurityAutoConfiguration.java
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/detail/AnnotationDetailEditorPanel.java
reckart added a commit that referenced this issue Jul 16, 2024
@reckart
Merge branch 'main' into refactoring/4882-Upgrade-to-Lucene-9
3255328 
* main: (49 commits)
  #4940 - OAuth and SAML logins do not work if a servlet path is used
  #4942 - Clearing hidden feature does sometimes not work
  No issue: Minor cleaning
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0-beta-1
  #4935 - Incorrect repetitions of sentences
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.2
  #4936 - Option to export project via remote API without any secondary format
  #4933 - Exporting project fails if a curation CAS is missing or document state is wrong
  No issue: Do not fail-fast
  No issue: Try caching the Maven repo
  #4916 - Support for MS SQL Server
  No issue: Formatting
  No issue: Small style fix
  No issue: Minor correction in format documentation
  #4929 - Unmergable annotations should be hidden in integrated curation mode
  #4843 - Promote sidebar curation mode to proper curation page
  #4925 - Retain ability to select users in curation sidebar in finished documents
  #4919 - Unable to import project with knowledge-based exported by INCEpTION 33.0 (again)
  ...

% Conflicts:
%	pom.xml
@reckart reckart mentioned this issue Jul 19, 2024
Closed
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Constraints
Projects
Kanban
Archived in project
Milestone
33.3
Development

No branches or pull requests
1 participant
@reckart