Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote sidebar curation mode to proper curation page #4843

Closed
reckart opened this issue Jun 1, 2024 · 0 comments
Closed

Promote sidebar curation mode to proper curation page #4843

reckart opened this issue Jun 1, 2024 · 0 comments

Comments

@reckart
Copy link
Member

reckart commented Jun 1, 2024

Describe the refactoring action
The sidebar curation mode is useful, but because it is a mode on the annotation page, it does not integrate well into proper workflow. E.g. when a user wants to use it to curate, they first need to access the annotation page and then enter the curation mode. When accessing the page, they first have to chose a document for annotation before they can activate the curation mode and then access the curation-mode-specific open-document dialog. It is odd.

Expected benefit
Having a (new) curation page which is basically the annotation page but with a permanently activated curation sidebar makes more sense. Also, the curation sidebar mode could then be removed again from the annotation page.

@reckart reckart self-assigned this Jun 1, 2024
@reckart reckart added this to the 34.0 milestone Jun 13, 2024
reckart added a commit that referenced this issue Jun 15, 2024
- Pull all code out of the AnnotationPage and into AnnotationPageBase2
- Add a new CurationPage that extends AnnotationPageBase2
- Rename the old CurationPage to LegacyCurationPage and similar classes accordingly
reckart added a commit that referenced this issue Jun 15, 2024
reckart added a commit that referenced this issue Jun 18, 2024
reckart added a commit that referenced this issue Jun 18, 2024
- Add configuration to switch between new and legacy curaiton page
reckart added a commit that referenced this issue Jun 18, 2024
- Add configuration to switch between new and legacy curaiton page
reckart added a commit that referenced this issue Jun 18, 2024
- Disable curation sidebar icon badge on curation page
- Change curation page URLs
- Added additional permission check to new curation page
- Display menu items for old/new curation pages only when they are enabled respectively in the curation panel of the project settings
- Ensure that activity dashlet points to the right curation page URL
- Disable curation session when entering annotation page unless curation sidebar is enabled
- Cleaning up
reckart added a commit that referenced this issue Jul 4, 2024
- Load list of curatable documents when accessing the curation page in integrated view
reckart added a commit that referenced this issue Jul 5, 2024
…ote-sidebar-curation-mode-to-proper-curation-page

#4843 - Promote sidebar curation mode to proper curation page
@reckart reckart closed this as completed Jul 5, 2024
reckart added a commit that referenced this issue Jul 16, 2024
* main: (49 commits)
  #4940 - OAuth and SAML logins do not work if a servlet path is used
  #4942 - Clearing hidden feature does sometimes not work
  No issue: Minor cleaning
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0-beta-1
  #4935 - Incorrect repetitions of sentences
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.2
  #4936 - Option to export project via remote API without any secondary format
  #4933 - Exporting project fails if a curation CAS is missing or document state is wrong
  No issue: Do not fail-fast
  No issue: Try caching the Maven repo
  #4916 - Support for MS SQL Server
  No issue: Formatting
  No issue: Small style fix
  No issue: Minor correction in format documentation
  #4929 - Unmergable annotations should be hidden in integrated curation mode
  #4843 - Promote sidebar curation mode to proper curation page
  #4925 - Retain ability to select users in curation sidebar in finished documents
  #4919 - Unable to import project with knowledge-based exported by INCEpTION 33.0 (again)
  ...

% Conflicts:
%	pom.xml
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant