Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default memory limit for INCEpTION in Dockerfile #4330

Closed
reckart opened this issue Nov 30, 2023 · 0 comments
Closed

Remove default memory limit for INCEpTION in Dockerfile #4330

reckart opened this issue Nov 30, 2023 · 0 comments
Assignees
@reckart
Labels
⚙️ Refactoring
Milestone
30.0

Comments

@reckart
Copy link
Member

reckart commented Nov 30, 2023

Describe the refactoring action
Remove default memory limit for INCEpTION in Dockerfile.

Expected benefit
If a memory limit is required, it should be specified by the user. Otherwise, INCEpTION should be allowed to take whatever memory is available to the Docker container.
@reckart reckart added this to the 30.0 milestone Nov 30, 2023
@reckart reckart self-assigned this Nov 30, 2023
reckart added a commit that referenced this issue Nov 30, 2023
@reckart
#4330 - Remove default memory limit for INCEpTION in Dockerfile
4a246c2 
- Removed default memory limit
reckart added a commit that referenced this issue Nov 30, 2023
@reckart
#4330 - Remove default memory limit for INCEpTION in Dockerfile
f29252d 
- Actually leave a limit in, but set it to 80 percent of the memory available to the container
reckart added a commit that referenced this issue Dec 1, 2023
@reckart
Merge pull request #4331 from inception-project/refactoring/4330-Remo…
acb8716 
…ve-default-memory-limit-for-INCEpTION-in-Dockerfile

#4330 - Change default memory limit for INCEpTION in Dockerfile
@reckart reckart closed this as completed Dec 1, 2023
reckart added a commit that referenced this issue Dec 1, 2023
@reckart
Merge branch 'release/30.x'
edde2be 
* release/30.x:
  #4330 - Remove default memory limit for INCEpTION in Dockerfile
  #4330 - Remove default memory limit for INCEpTION in Dockerfile
reckart added a commit that referenced this issue Dec 1, 2023
@reckart
Merge branch 'main' into feature/4292-ollama-based-recommender
ef92437 
* main:
  #4330 - Remove default memory limit for INCEpTION in Dockerfile
  #4229 - Better project template selection
  #4330 - Remove default memory limit for INCEpTION in Dockerfile
  #4229 - Better project template selection
reckart added a commit that referenced this issue Dec 5, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
4aa1324 
* main:
  #4347 - CAS doctor fails to generate a proper report on projects not containing INITIAL_CASes
  #4349 - Project has date in the 70ies if no data is set in JSON
  #4344 - Allow format to inject default namespace if document does not specify one
  #4342 - Show document size in documents table
  #4342 - Show document size in documents table
  No issue: Optimize tracking be excluding elements that contain no text
  No issue: Avoid scrollbar appearing at wrong level
  #4340 - Allow pruning elements in XML policy
  #4338 - Spurious empty annotations in RecogitoJS editor
  #4324 - Allow configuring UID GID etc in Kubernetes
  #4335 - Promote UIMA JSON CAS 0.4.0 to non-experimental
  #4326 - Upgrade dependencies
  #4330 - Remove default memory limit for INCEpTION in Dockerfile
  #4229 - Better project template selection
  #4330 - Remove default memory limit for INCEpTION in Dockerfile
  #4229 - Better project template selection

% Conflicts:
%	inception/inception-external-editor/src/main/java/de/tudarmstadt/ukp/inception/externaleditor/xhtml/XHtmlXmlDocumentViewControllerImpl.java
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⚙️ Refactoring
Projects
Kanban
Archived in project
Milestone
30.0
Development

No branches or pull requests
1 participant
@reckart