Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save memory by not creating empty arrays in CAS #4196

Closed
reckart opened this issue Sep 20, 2023 · 0 comments
Closed

Save memory by not creating empty arrays in CAS #4196

reckart opened this issue Sep 20, 2023 · 0 comments
Assignees
@reckart
Labels
Module: Annotation ⚙️ Refactoring
Milestone
30.0

Comments

@reckart
Copy link
Member

reckart commented Sep 20, 2023

Describe the refactoring action
Instead of storing empty arrays in the CAS, the array reference should just be set to null.

Expected benefit
Less memory usage (minimal, but ok).
@reckart reckart added this to the 30.0 milestone Sep 20, 2023
@reckart reckart self-assigned this Sep 20, 2023
reckart added a commit that referenced this issue Sep 20, 2023
@reckart
#4196 - Save memory by not creating empty arrays in CAS
9f626b3 
- Adjust link features and multi-value features to not store empty arrays
reckart added a commit that referenced this issue Sep 21, 2023
@reckart
Merge pull request #4197 from inception-project/refactoring/4196-Save…
2973c24 
…-memory-by-not-creating-empty-arrays-in-CAS

#4196 - Save memory by not creating empty arrays in CAS
@reckart reckart closed this as completed Sep 21, 2023
reckart added a commit that referenced this issue Sep 23, 2023
@reckart
Merge branch 'main' into bugfix/4158-Exception-when-annotating-someth…
f14ef36 
…ing-after-a-longer-pause

* main:
  #4158 - Exception when annotating something after a longer pause
  No issue: Enable parallel builds
  #4158 - Exception when annotating something after a longer pause
  #4158 - Exception when annotating something after a longer pause
  #4192 - Upgrade dependencies
  #4201 - Layer export as JSON does not include coloring rules
  #4199 - Jumping to the end of a long annotation sometimes does not work
  #4198 - Show layer name instead of no-label
  #4196 - Save memory by not creating empty arrays in CAS

% Conflicts:
%	inception/inception-diag/src/main/java/de/tudarmstadt/ukp/clarin/webanno/diag/checks/UnreachableAnnotationsCheck.java
%	inception/inception-diag/src/main/java/de/tudarmstadt/ukp/clarin/webanno/diag/config/CasDoctorAutoConfiguration.java
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
Module: Annotation ⚙️ Refactoring
Projects
Kanban
Archived in project
Milestone
30.0
Development

No branches or pull requests
1 participant
@reckart