Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when annotating something after a longer pause #4158

Closed
reckart opened this issue Aug 25, 2023 · 1 comment
Closed

Exception when annotating something after a longer pause #4158

reckart opened this issue Aug 25, 2023 · 1 comment
Assignees
Labels
🐛Bug Something isn't working Module: Annotation
Milestone

Comments

@reckart
Copy link
Member

reckart commented Aug 25, 2023

Describe the bug
Sometimes, there is an exception when performing an action in the annotation editor (like annotating something, selecting an annotation or simply reloading) after a longer pause. This seems to happen in particular when recommenders are active in the background.

To Reproduce
Steps to reproduce the behavior:

  1. Configure a recommender in the project
  2. Set the eviction timeout to a low value cas-storage.cache.idle-cas-eviction-delay=5s
  3. Create annotations, delete annotations, select stuff, sometimes waiting longer than 5s in between
  4. Eventually, an exception should be thrown that no FS with the given ID could be found in the CAS

Expected behavior
No such exception.

Please complete the following information:

  • Version and build ID: 29.0
@reckart reckart self-assigned this Aug 25, 2023
@reckart reckart added the 🐛Bug Something isn't working label Aug 25, 2023
@reckart reckart added this to the 30.0 milestone Aug 25, 2023
reckart added a commit that referenced this issue Aug 25, 2023
- It should be ok to load a CAS without upgrading (no auto-cas upgrade) when loading in shared mode
reckart added a commit that referenced this issue Aug 25, 2023
- It should be ok to load a CAS without upgrading (no auto-cas upgrade) when loading in shared mode
reckart added a commit that referenced this issue Aug 25, 2023
reckart added a commit that referenced this issue Sep 20, 2023
- Added new CAS Doctor check for unreachable feature structures
- Added new CAS Doctor repair for unreachable feature structures
- Improved logging in storage system
- Improves storage utilities
@reckart
Copy link
Member Author

reckart commented Sep 20, 2023

The root of the problem is an upstream issue: apache/uima-uimaj#345

The SelectFS may create temporary annotations which are not tracked in the CAS but which consume IDs. These are not serialized. When reconstructing the IDs from a serialized CAS, the IDs of the non-serialized temporary annotations cannot be accounted for leading to the IDs of the FSes in the loaded CAS to differ from the ones in the original CAS.

reckart added a commit that referenced this issue Sep 20, 2023
- Added new CAS Doctor check for unreachable feature structures
- Added new CAS Doctor repair for unreachable feature structures
- Improved logging in storage system
- Improves storage utilities
reckart added a commit that referenced this issue Sep 23, 2023
- Replace calls to SelectFS with calls to CASUtil which does not create temporary annotations
reckart added a commit that referenced this issue Sep 23, 2023
- Added new CAS Doctor check for unreachable feature structures
- Updated UpgradeCasRepair to report garbarge-collected feature structures
- Updated description of UpgradeCasRepair
reckart added a commit that referenced this issue Sep 23, 2023
reckart added a commit that referenced this issue Sep 23, 2023
…-when-annotating-something-after-a-longer-pause-29.x

#4158 - Exception when annotating something after a longer pause
@reckart reckart closed this as completed Sep 23, 2023
@reckart reckart modified the milestones: 30.0, 29.3 Sep 23, 2023
reckart added a commit that referenced this issue Sep 23, 2023
* release/29.x:
  #4158 - Exception when annotating something after a longer pause
  No issue: Enable parallel builds
  #4158 - Exception when annotating something after a longer pause
  #4158 - Exception when annotating something after a longer pause

% Conflicts:
%	Jenkinsfile
reckart added a commit that referenced this issue Sep 23, 2023
…ing-after-a-longer-pause

* main:
  #4158 - Exception when annotating something after a longer pause
  No issue: Enable parallel builds
  #4158 - Exception when annotating something after a longer pause
  #4158 - Exception when annotating something after a longer pause
  #4192 - Upgrade dependencies
  #4201 - Layer export as JSON does not include coloring rules
  #4199 - Jumping to the end of a long annotation sometimes does not work
  #4198 - Show layer name instead of no-label
  #4196 - Save memory by not creating empty arrays in CAS

% Conflicts:
%	inception/inception-diag/src/main/java/de/tudarmstadt/ukp/clarin/webanno/diag/checks/UnreachableAnnotationsCheck.java
%	inception/inception-diag/src/main/java/de/tudarmstadt/ukp/clarin/webanno/diag/config/CasDoctorAutoConfiguration.java
reckart added a commit that referenced this issue Sep 23, 2023
reckart added a commit that referenced this issue Sep 23, 2023
reckart added a commit that referenced this issue Sep 23, 2023
reckart added a commit that referenced this issue Sep 23, 2023
…-when-annotating-something-after-a-longer-pause

#4158 - Exception when annotating something after a longer pause
reckart added a commit that referenced this issue Oct 2, 2023
* main: (42 commits)
  #4221 - Upgrade dependencies
  #4219 - Improve speed of importing a large KB
  #4217 - Speed up properties list loading on KB page
  #4209 - Improve query speed for large KBs when using RDF4J Lucene FTS
  #4212 - Unable to mark local KB as read-only
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.3
  No issue. Fix PubMed test.
  #4192 - Upgrade dependencies
  No issue. Fix PubMed test.
  #4205 - Ability to refresh document to load pending suggestions
  #4158 - Exception when annotating something after a longer pause
  #4158 - Exception when annotating something after a longer pause
  No issue: Enable parallel builds
  #4158 - Exception when annotating something after a longer pause
  #4158 - Exception when annotating something after a longer pause
  #4192 - Upgrade dependencies
  #4201 - Layer export as JSON does not include coloring rules
  #4199 - Jumping to the end of a long annotation sometimes does not work
  #4198 - Show layer name instead of no-label
  ...

% Conflicts:
%	inception/inception-workload-dynamic/src/main/java/de/tudarmstadt/ukp/inception/workload/dynamic/annotation/DynamicAnnotatorWorkflowActionBarItemGroup.java
%	pom.xml
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Annotation
Projects
Archived in project
Development

No branches or pull requests

1 participant