-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order of matches found in knowledge base search is not correct #3822
Comments
@ahoo Thanks for the report - very insightful! I can reproduce the issue and am looking into a fix. |
Thanks. Preferred label is also ok! However, our annotators can be more confident if they see the exact match on the top of list ( which is hand ). |
Would you then expect to see only The label rendered on top of the text in the annotation bubble will always be the preferred label. I believe it would confuse the annotators if the item they chose is not the item that will be rendered in the text then. I guess the best way would be to display in the item both, the preferred label and the label that had the best match....?Unfortunately also the more complicated solution to implement ;) |
- Properly additional match labels in the SPARQLQueryBuilder - Use the additional match labels when ranking using the LevenshteinFeatureGenerator
Is it possible to see both? it is now the preferred name and the link to Snomed. If there is no room for everything to be shown, I believe the link can be replaced by the label that had the best match... |
IMHO the IRI should also remain visible because some people enter the IRI directly and they should be able to compare what they entered to the items in the dropdown. |
very valid point. It is important that annotators can put the IRI |
yes, looks exactly like what we want! Is there a reason than "hand bath" is the second match? and not "handicap"? I am trying to understand the sorting algorithm. Thank you |
Ok, there is a longer story here :) First, I had to change the settings in the project that you provided a bit - it was missing the settings to take the alternative labels into account: In the screenshot above, I only had added In the gray debug info, you can see that |
- If the best match term differs from the KBHandle primary UI label, display it also in the dropdown
Thank you for explanation. It makes sense. I am very happy with the output |
…matches-found-in-knowledge-base-search-is-not-correct #3822 - Order of matches found in knowledge base search is not correct
You can try this out in INCEpTION 27.0-beta-4: https://inception-project.github.io/downloads-beta/ |
thank you Richard, I tested it and it works as expected. Will you make a release in the coming days? |
I hope 27.0 can be released within the next 14 days - but I never give guarantees :) If for some reason it should get delayed, a 26.9 release can be added in between and that would also include the fix. |
* main: (212 commits) No issue. Pull CSS out of HTML file and into a separate CSS file. #3831 - Better support a direct-access workflow #3831 - Better support a direct-access workflow #3831 - Better support a direct-access workflow No issue: Avoid hard crash if selection points to a non-existing feature structure. No issue: Formatting No issue: Fix endless recursion. No issue. Make some constants accessible. #3571 - Update dependencies #3571 - Update dependencies #3826 - Update dependencies #3783 - Ability to sort projects by created date #3826 - Update dependencies [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release inception-27.0-beta-4 #3822 - Order of matches found in knowledge base search is not correct #3822 - Order of matches found in knowledge base search is not correct #3822 - Order of matches found in knowledge base search is not correct No issue. Reduce memory usage of test and display memory usage while test is running. #3793 - Ability to trigger sidebar curation mode via URL parameter ... % Conflicts: % inception/inception-app-webapp/src/main/java/de/tudarmstadt/ukp/inception/app/config/InceptionSecurityWebUIBuiltInAutoConfiguration.java % inception/inception-app-webapp/src/main/java/de/tudarmstadt/ukp/inception/app/config/InceptionSecurityWebUIPreAuthenticatedAutoConfiguration.java % inception/inception-app-webapp/src/main/java/de/tudarmstadt/ukp/inception/app/config/InceptionServletContextInitializer.java % inception/inception-diam-editor/src/main/java/de/tudarmstadt/ukp/inception/experimental/editor/diamdebugeditor/DiamDebugEditorComponent.java % inception/inception-html-editor/pom.xml % inception/inception-security/src/main/java/de/tudarmstadt/ukp/clarin/webanno/security/config/SecurityAutoConfiguration.java % inception/inception-security/src/main/java/de/tudarmstadt/ukp/clarin/webanno/security/preauth/ShibbolethRequestHeaderAuthenticationFilter.java % inception/inception-support/src/main/java/de/tudarmstadt/ukp/inception/support/vue/VueBehavior.java % inception/inception-tutorial/src/main/java/de/tudarmstadt/ukp/inception/tutorial/TutorialFooterPanel.java % inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/config/AnnotationUIAutoConfiguration.java % inception/inception-ui-core/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/core/login/LoginPage.java % inception/inception-ui-core/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/core/page/ProjectPageBase.java % inception/inception-ui-curation/src/main/java/de/tudarmstadt/ukp/inception/ui/curation/sidebar/config/CurationSidebarAutoConfiguration.java % inception/inception-websocket/pom.xml % inception/inception-websocket/src/main/java/de/tudarmstadt/ukp/inception/websocket/footer/LoggedEventFooterPanel.java % inception/pom.xml
There will not be a version 26.9. A release candidate 27.0-rc-1 is now available and you may consider testing it: https://github.com/inception-project/inception/releases/tag/inception-27.0-rc-1 |
@reckart Is it accessible via docker ? |
For future reference - when configuring INCEpTION for Snomed, the following settings should be made:
|
Describe the bug
Our knowledge base has different string properties ( for example prefLabel, altLabel, label ). We like to get the entity with closest match in all of these properties, for example, if I search for "hand", the entity with altlabel "hand" should be shown on top of list.
To Reproduce
I have attached the project and the knowledge base.
import knowledge base local with IRI Schema
After importing knowledge base is done, search "hand"
Expected behavior
it should show "Hand structure (body structure)" on top of the results for search.
same as search results as Snomed browser https://browser.ihtsdotools.org/?perspective=full&conceptId1=85562004&edition=MAIN/2023-01-31&release=&languages=en&latestRedirect=false
Screenshots
But we expect this order:
Please complete the following information:
Additional context
The project and kb file is attached
hand_project16118132736551889752.zip
vomiting_hand_graph.ttl.zip
The text was updated successfully, but these errors were encountered: