Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old database migrations that seem to get always executed #3407

Closed
reckart opened this issue Sep 30, 2022 · 0 comments
Closed

Remove old database migrations that seem to get always executed #3407

reckart opened this issue Sep 30, 2022 · 0 comments
Assignees
@reckart
Labels
⚙️ Refactoring
Milestone
34.0

Comments

@reckart
Copy link
Member

reckart commented Sep 30, 2022

Describe the refactoring action
There are some database migrations that appear to be always executed. It seems at least some of them are removing indexes from ancient WebAnno versions that were created there when we still used Hibernate to maintain the schema. It would seem these migrations could removed now:

Running Changeset: de/tudarmstadt/ukp/clarin/webanno/security/model/db-changelog.xml::1512223050574-4.1::WebAnno Team
Running Changeset: de/tudarmstadt/ukp/clarin/webanno/model/db-changelog.xml::1512223050574-1.1::WebAnno Team
Running Changeset: de/tudarmstadt/ukp/clarin/webanno/model/db-changelog.xml::1512223050574-2.1::WebAnno Team
Running Changeset: de/tudarmstadt/ukp/clarin/webanno/model/db-changelog.xml::1512223050574-3.1::WebAnno Team
Running Changeset: de/tudarmstadt/ukp/clarin/webanno/model/db-changelog.xml::1512223050574-6.1::WebAnno Team
Running Changeset: de/tudarmstadt/ukp/clarin/webanno/model/db-changelog.xml::1512223050574-9.1::WebAnno Team
Running Changeset: de/tudarmstadt/ukp/clarin/webanno/model/db-changelog.xml::1512223050574-10.1::WebAnno Team
Running Changeset: de/tudarmstadt/ukp/clarin/webanno/model/db-changelog.xml::1512223050574-11.1::WebAnno Team
Running Changeset: de/tudarmstadt/ukp/clarin/webanno/model/db-changelog.xml::1512223050574-13.1::WebAnno Team
Running Changeset: de/tudarmstadt/ukp/clarin/webanno/model/db-changelog.xml::1512223050574-14.1::WebAnno Team
Running Changeset: de/tudarmstadt/ukp/clarin/webanno/model/db-changelog.xml::20220528-1::INCEpTION Team

Need to check all of these migrations - there may be some with a different background/history.

Expected benefit
Avoid running certain migrations every time the application starts.
@reckart reckart added this to the 25.0 milestone Sep 30, 2022
@reckart reckart self-assigned this Sep 30, 2022
@reckart reckart modified the milestones: 25.0, 26.0 Oct 2, 2022
@reckart reckart modified the milestones: 26.0, 27.0 Nov 5, 2022
@reckart reckart modified the milestones: 27.0, 28.0 Jan 4, 2023
@reckart reckart modified the milestones: 28.0, 29.0 May 2, 2023
@reckart reckart modified the milestones: 29.0, 30.0 Jul 29, 2023
@reckart reckart modified the milestones: 30.0, 31.0 Sep 19, 2023
@reckart reckart modified the milestones: 31.0, 32.0 Jan 6, 2024
@reckart reckart modified the milestones: 32.0, ⭐️ Feature backlog Feb 6, 2024
@reckart reckart modified the milestones: ⭐️ Feature backlog, 34.0 Jun 28, 2024
reckart added a commit that referenced this issue Jun 29, 2024
@reckart
#3407 - Remove old database migrations that seem to get always executed
1300a79 
- Removed the migrations from the WebAnno era that delete indexes that were created before Liquibase was introduced
reckart added a commit that referenced this issue Jun 29, 2024
@reckart
#3407 - Remove old database migrations that seem to get always executed
b6fae19 
- Removed the migrations from the WebAnno era that delete indexes that were created before Liquibase was introduced
reckart added a commit that referenced this issue Jun 29, 2024
@reckart
#3407 - Remove old database migrations that seem to get always executed
b840494 
- Removed the migrations from the WebAnno era that delete indexes that were created before Liquibase was introduced
reckart added a commit that referenced this issue Jun 29, 2024
@reckart
#3407 - Remove old database migrations that seem to get always executed
2772792 
- Removed the migrations from the WebAnno era that delete indexes that were created before Liquibase was introduced
reckart added a commit that referenced this issue Jun 29, 2024
@reckart
#3407 - Remove old database migrations that seem to get always executed
a9dde86 
- Removed the migrations from the WebAnno era that delete indexes that were created before Liquibase was introduced
reckart added a commit that referenced this issue Jun 29, 2024
@reckart
Merge pull request #4913 from inception-project/refactoring/3407-Remo…
1ae3fa3 
…ve-old-database-migrations-that-seem-to-get-always-executed

#3407 - Remove old database migrations that seem to get always executed
@reckart reckart closed this as completed Jun 29, 2024
reckart added a commit that referenced this issue Jul 3, 2024
@reckart
Merge branch 'main' into refactoring/4843-Promote-sidebar-curation-mo…
eb1427a 
…de-to-proper-curation-page

* main: (24 commits)
  #4919 - Unable to import project with knowledge-based exported by INCEpTION 33.0 (again)
  #4921 - Constraints do not work properly when rules are distributed over multiple rulesets
  #4915 - Support for MySQL 8
  #4051 - Postgres support
  #3407 - Remove old database migrations that seem to get always executed
  #3407 - Remove old database migrations that seem to get always executed
  #4909 - Upgrade dependencies
  #4911 - No results when searching as curator after re-indexing project
  #4909 - Upgrade dependencies
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.1
  #4901 - Consider document structure when splitting sentences in custom XML formats
  #4880 - Upgrade dependencies
  #4898 - Unable to import project with knowledge-based exported by INCEpTION 33.0
  #4896 - Ability to search for additional languages in knowledge-base
  No issue: Trim LLM responses
  #4892 - Curation sidebar state not cleared when logging out
  #4891 - Exception in sidebar curation mode when document-level annotations exist
  #4727 - Switching between editors can cause the old and the new editors to be loaded and initialized
  #4889 - Document sometimes not rendered in by-line brat render modes
  ...

% Conflicts:
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/AnnotationPage.java
reckart added a commit that referenced this issue Jul 3, 2024
@reckart
Merge branch 'main' into refactoring/4843-Promote-sidebar-curation-mo…
440c304 
…de-to-proper-curation-page

* main: (24 commits)
  #4919 - Unable to import project with knowledge-based exported by INCEpTION 33.0 (again)
  #4921 - Constraints do not work properly when rules are distributed over multiple rulesets
  #4915 - Support for MySQL 8
  #4051 - Postgres support
  #3407 - Remove old database migrations that seem to get always executed
  #3407 - Remove old database migrations that seem to get always executed
  #4909 - Upgrade dependencies
  #4911 - No results when searching as curator after re-indexing project
  #4909 - Upgrade dependencies
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.1
  #4901 - Consider document structure when splitting sentences in custom XML formats
  #4880 - Upgrade dependencies
  #4898 - Unable to import project with knowledge-based exported by INCEpTION 33.0
  #4896 - Ability to search for additional languages in knowledge-base
  No issue: Trim LLM responses
  #4892 - Curation sidebar state not cleared when logging out
  #4891 - Exception in sidebar curation mode when document-level annotations exist
  #4727 - Switching between editors can cause the old and the new editors to be loaded and initialized
  #4889 - Document sometimes not rendered in by-line brat render modes
  ...

% Conflicts:
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/AnnotationPage.java
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⚙️ Refactoring
Projects
Kanban
Archived in project
Milestone
34.0
Development

No branches or pull requests
1 participant
@reckart