Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curation mode does not render cross-sentence relations #1959

Closed
ofersabo opened this issue Jan 23, 2021 · 4 comments
Closed

Curation mode does not render cross-sentence relations #1959

ofersabo opened this issue Jan 23, 2021 · 4 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Annotation Module: brat Module: Curation
Milestone
33.0

Comments

@ofersabo
Copy link

Working with two layers, a span layer, and a relation layer.
The relation layers "Allow crossing sentence boundaries" check box is enabled.

An annotator mark a cross sentence relation could be any relation.
When this document is opened in curation mode, then this cross-relation connection is gone.

To Reproduce
Steps to reproduce the behavior:

  1. create a project with two layers, span, and relation.
  2. connect a span with relation from a different sentence
  3. finish the document
  4. go to the curation mode
  5. See the error

Expected behavior
relation appears also within curation mode.

Please complete the following information:

  • Version and build ID: 0.17.4 (2021-01-13 23:39:05, build 2bb5cd9)
  • OS X
  • Browser: chrome
@reckart
Copy link
Member

reckart commented Jan 23, 2021

For a relation to be visible, the start and end position of the relation must be on screen. Did you configure the view in the curation mode to show enough sentences so that start and end show up?

@reckart
Copy link
Member

reckart commented Jan 23, 2021

I might have an idea how to fix that long-standing issue about these relations not showing up.... I'll try to play around with the idea - if it works out, maybe we can get it into 0.18

@reckart reckart added Module: Curation 🐛Bug Something isn't working labels Feb 6, 2021
@reckart reckart added this to the 🦟 Bug backlog milestone Feb 6, 2021
@reckart reckart self-assigned this Feb 6, 2021
@reckart reckart modified the milestones: 🦟 Bug backlog, 0.19.1 Mar 14, 2021
@reckart reckart modified the milestones: 0.19.1, 0.19.2 Mar 23, 2021
@reckart
Copy link
Member

reckart commented Mar 24, 2021

I'll assume that the relation did/would show up once you set the window size accordingly.

So we have the issue left of improving the editor to given an indication of relations reaching beyond the boundaries of the window.

@reckart reckart modified the milestones: 0.19.2, 0.20.0 Mar 24, 2021
@reckart reckart added ⭐️ Enhancement New feature or request Module: Annotation and removed 🐛Bug Something isn't working labels Mar 24, 2021
@reckart reckart modified the milestones: 0.20.0, 0.21.0 Apr 14, 2021
@reckart
Copy link
Member

reckart commented Jun 19, 2021

We have the rendering of partially-visible spans now: #2342

Partial relations not yet...

@reckart reckart added 🐛Bug Something isn't working and removed ⭐️ Enhancement New feature or request labels Jul 6, 2021
@reckart reckart modified the milestones: 0.21.0, 🦟 Bug backlog Jul 6, 2021
@reckart reckart modified the milestones: 🦟 Bug backlog, 21.0 Aug 4, 2021
@reckart reckart modified the milestones: 21.0, 21.1 Sep 1, 2021
@reckart reckart modified the milestones: 21.1, 21.2 Oct 18, 2021
@reckart reckart removed this from the 21.2 milestone Nov 30, 2021
@reckart reckart modified the milestones: 25.0, 26.0 Sep 30, 2022
@reckart reckart modified the milestones: 26.0, 27.0 Nov 5, 2022
@reckart reckart modified the milestones: 27.0, 28.0 Jan 4, 2023
@reckart reckart modified the milestones: 28.0, 29.0 May 2, 2023
@reckart reckart modified the milestones: 29.0, 30.0 Jul 29, 2023
@reckart reckart modified the milestones: 30.0, 31.0 Nov 5, 2023
@reckart reckart modified the milestones: 31.0, 32.0 Jan 6, 2024
@reckart reckart modified the milestones: 32.0, ⭐️ Feature backlog Feb 6, 2024
@reckart reckart modified the milestones: ⭐️ Feature backlog, 33.0 Jun 4, 2024
@reckart reckart changed the title Curation mode ignores cross sentence relation Curation mode does not render cross-sentence relations Jun 4, 2024
reckart added a commit that referenced this issue Jun 4, 2024
@reckart
#1959 - Curation mode does not render cross-sentence relations
17921c9 
- Port cross-sentence rendering improvements from the brat annotation editor into the legacy curation page and diff adapters
reckart added a commit that referenced this issue Jun 4, 2024
@reckart
Merge pull request #4848 from inception-project/bugfix/1959-Curation-…
ac0e9cd 
…mode-does-not-render-cross-sentence-relations

#1959 - Curation mode does not render cross-sentence relations
@reckart reckart closed this as completed Jun 4, 2024
reckart added a commit that referenced this issue Jun 4, 2024
@reckart
Merge branch 'main' into refactoring/4844-Write-project-export-direct…
4184cb9 
…ly-to-ZIP-file

* main:
  #1959 - Curation mode does not render cross-sentence relations
  #4846 - Control JUL bridge using a dedicated property
reckart added a commit that referenced this issue Jun 5, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
c444472 
* main: (47 commits)
  #4854 - Upgrade dependencies
  #1959 - Curation mode does not render cross-sentence relations
  #4846 - Control JUL bridge using a dedicated property
  #4745 - Upgrade dependencies
  #4745 - Upgrade dependencies
  #4835 - Error when trying to open certain documents with stacked annotations for curation
  #4839 - Scrolling to selection does sometimes not work in Apache Annotator Editor
  #4809 - Connecting annotation and entity with arc over different pages
  #4809 - Connecting annotation and entity with arc over different pages
  #4809 - Connecting annotation and entity with arc over different pages
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.0-beta-3
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-32.3
  #4832 - Improve self-help for reverse proxies
  #4832 - Improve self-help for reverse proxies
  #4832 - Improve self-help for reverse proxies
  #4830 - Cannot enable logging for JUL-based libraries
  #4809 - Connecting annotation and entity with arc over different pages
  #4809 - Connecting annotation and entity with arc over different pages
  ...

% Conflicts:
%	inception/inception-app-webapp/pom.xml
%	inception/inception-constraints/src/main/java/de/tudarmstadt/ukp/clarin/webanno/constraints/ConstraintsServiceImpl.java
%	inception/inception-recommendation/pom.xml
%	inception/inception-schema/src/main/java/de/tudarmstadt/ukp/inception/schema/service/AnnotationSchemaServiceImpl.java
%	inception/inception-search-core/src/main/java/de/tudarmstadt/ukp/inception/search/SearchServiceImpl.java
%	pom.xml
reckart added a commit that referenced this issue Jun 15, 2024
@reckart
Merge branch 'main' into refactoring/4843-Promote-sidebar-curation-mo…
e8c0cc4 
…de-to-proper-curation-page

* main:
  #1319 - Cross-Layer Relations
  #4064 - Support for agreement calculation on document-level annotations
  #4860 - Knowledge base items should be matched even if query contains terms out of order
  #4858 - Option to not finish bulk-processed documents if no annotations were accepted
  #4064 - Support for agreement calculation on document-level annotations
  #4844 - Write project export directly to ZIP file
  #4853 - Detail popover on curation suggestions does not show lazy details when using sidebar curation mode
  #4854 - Upgrade dependencies
  #4844 - Write project export directly to ZIP file
  #4844 - Write project export directly to ZIP file
  #1959 - Curation mode does not render cross-sentence relations
  #4844 - Write project export directly to ZIP file
  #4846 - Control JUL bridge using a dedicated property
  #4745 - Upgrade dependencies
  #4745 - Upgrade dependencies
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Annotation Module: brat Module: Curation
Projects
Kanban
Archived in project
Milestone
33.0
Development

No branches or pull requests
2 participants
@reckart @ofersabo