-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "default is a reserved keyword" error no-named-default tests #757
Conversation
Anyone know how to restart travis-ci? It's clearly hung. |
2 similar comments
I'm glad we figured this out - but I think if the parsing error is per-spec, that we should instead fix the code. |
I would recommend removing this test (possibly the rule?) since most environments throw an exception when assign variables to Safari 10.0.3 (12602.4.8)
Chrome 56.0.2924.87
Firefox 51.0.1
Node 6.9.1
@ljharb I'm following @ntdb's recommendation to leave the test in and downgrade the library. My only goal is to get tests to pass so I can unblock quite a few PRs (selfishly #754 😄) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good for now, but we should work on a PR that addresses the test and unpins the dependency, ASAP.
#756