no-named-default test failure

[gmathieu]

@ntdb looks like a lot of PRs are failing because of the following error:

default is a reserved word

Is it okay to disable this test?

[ntdb]

Interesting... @jfmengels any thoughts on this? I'm hesitant to just disable a spec but obviously we need builds to run.

[ljharb]

Can we pin down what dep update is causing the error?

[gmathieu]

I've created a diff between the latest passing PR build 1849 and my branch's build 1858.

--- passing.txt    Tue Feb 28 16:12:34 2017
+++ failing.txt    Tue Feb 28 16:12:37 2017
@@ -5,7 +5,7 @@
 | | `-- [email protected]
 | +-- [email protected]
 | | `-- [email protected]
-| +-- [email protected]
+| +-- [email protected]
 | +-- [email protected]
 | | +-- [email protected]
 | | | `-- [email protected]
@@ -62,8 +62,8 @@
 |   | | `-- [email protected]
 |   | +-- [email protected]
 |   | +-- [email protected]
-|   | | +-- [email protected]
-|   | | | `-- [email protected]
+|   | | +-- [email protected]
+|   | | | `-- [email protected]
 |   | | `-- [email protected]
 |   | +-- [email protected]
 |   | | +-- [email protected]
@@ -186,7 +186,7 @@
 +-- [email protected]
 | +-- [email protected]
 | `-- [email protected]
-+-- [email protected]
++-- [email protected]
 | +-- [email protected]
 | | `-- [email protected]
 | +-- [email protected]
@@ -196,7 +196,7 @@
 | | `-- [email protected]
 | +-- [email protected]
 | | +-- [email protected]
-| | +-- [email protected]
+| | +-- [email protected]
 | | | +-- [email protected]
 | | | +-- [email protected]
 | | | +-- [email protected]
@@ -232,7 +232,7 @@
 | | +-- [email protected]
 | | `-- [email protected]
 | +-- [email protected]
-| +-- [email protected]
+| +-- [email protected]
 | +-- [email protected]
 | +-- [email protected]
 | | +-- [email protected]
@@ -252,7 +252,7 @@
 | | +-- [email protected]
 | | +-- [email protected]
 | | `-- [email protected]
-| +-- [email protected]
+| +-- [email protected]
 | | +-- [email protected]
 | | +-- [email protected]
 | | | `-- [email protected]
@@ -291,7 +291,8 @@
 | `-- [email protected]
 |   `-- [email protected]
 +-- [email protected]  invalid
-| `-- [email protected]
+| `-- [email protected]
+|   `-- [email protected]
 +-- [email protected]
 | +-- [email protected]
 | +-- [email protected]
@@ -324,14 +325,16 @@
 | | | | | `-- [email protected]
 | | | | +-- [email protected]
 | | | | | `-- [email protected]
-| | | | |   `-- [email protected]
 | | | | `-- [email protected]
 | | | +-- [email protected]
 | | | | +-- [email protected]
 | | | | +-- [email protected]
-| | | | +-- [email protected]
-| | | | | +-- [email protected]
-| | | | | `-- [email protected]
+| | | | +-- [email protected]
+| | | | | +-- [email protected]
+| | | | | +-- [email protected]
+| | | | | +-- [email protected]
+| | | | | +-- [email protected]
+| | | | | `-- [email protected]
 | | | | `-- [email protected]
 | | | |   `-- [email protected]
 | | | +-- [email protected]
@@ -490,7 +493,7 @@
 | | +-- [email protected]
 | | | `-- [email protected]
 | | +-- [email protected]
-| | `-- [email protected]
+| | `-- [email protected]
 | |   +-- [email protected]
 | |   +-- [email protected]
 | |   `-- [email protected]
@@ -516,8 +519,9 @@
 +-- [email protected]
 | +-- [email protected]
 | | `-- [email protected]
-| `-- [email protected]
-|   `-- [email protected]
+| +-- [email protected]
+| | `-- [email protected]
+| `-- [email protected]
 +-- [email protected]
 +-- [email protected]
 | `-- [email protected]
@@ -741,8 +745,8 @@
 | +-- [email protected]
 | +-- [email protected]
 | `-- [email protected]
-+-- [email protected]
-+-- UNMET PEER DEPENDENCY [email protected]
++-- [email protected]
++-- UNMET PEER DEPENDENCY [email protected]
 +-- [email protected]
 | `-- [email protected]
 |   `-- [email protected]

I even tried locking the dependencies to the previous build but no luck

"devDependencies": {
    "babel-eslint": "6.0.0-beta.6",
    "babel-plugin-istanbul": "2.0.3",
    "babel-preset-es2015-argon": "0.1.0",
    "babel-register": "6.16.3",
    "chai": "3.5.0",
    "coveralls": "2.11.16",
    "cross-env": "3.1.4",
    "eslint": "3.15.0",
    "eslint-import-resolver-node": "file:./resolvers/node",
    "eslint-import-resolver-webpack": "file:./resolvers/webpack",
    "eslint-module-utils": "file:./utils",
    "eslint-plugin-import": "2.2.0",
    "gulp": "3.9.1",
    "gulp-babel": "6.1.2",
    "istanbul": "0.4.5",
    "linklocal": "2.8.0",
    "mocha": "3.2.0",
    "nyc": "8.4.0",
    "redux": "3.6.0",
    "rimraf": "2.6.0",
    "typescript": "2.1.6",
    "typescript-eslint-parser": "1.0.3"
  },
  "peerDependencies": {
    "eslint": "2.x - 3.x"
  },
  "dependencies": {
    "builtin-modules": "1.1.1",
    "contains-path": "0.1.0",
    "debug": "2.6.1",
    "doctrine": "1.5.0",
    "eslint-import-resolver-node": "0.2.3",
    "eslint-module-utils": "2.0.0",
    "has": "1.0.1",
    "lodash.cond": "4.5.2",
    "minimatch": "3.0.3",
    "read-pkg-up": "2.0.0"
  },

[ljharb]

Maybe babylon - if you npm install [email protected] and rerun, do tests pass?

[gmathieu]

@ljharb that did it. I'll have a PR ready in a bit.

[ljharb]

Great, that narrows it down :-) I think rather than locking down the dep, we should fix the code (or, if the error isn't spec-compliant, push upstream so babylon fixes it)

[danez]

The code in the test is invalid. default is not a valid local identifier in this case. Most parsers fail on this code and babylon now also does in 6.16.0.
Imho the test should be dropped. Other valid cases like import { default as x } are already tested.

Should I create a PR?

[ljharb]

Yes, a PR to remove the test seems prudent, thanks.