Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.8.1, webpack/0.2.5 #353

Merged
merged 3 commits into from
May 26, 2016
Merged

Release v1.8.1, webpack/0.2.5 #353

merged 3 commits into from
May 26, 2016

Conversation

benmosher
Copy link
Member

@benmosher benmosher commented May 23, 2016

Releasing bugfixes + minor improvements to core plugin + Webpack resolver.
#332 feels semver-minor because it's large, but in all likelihood it just hasn't impacted anyone before @jkimbo brought it up. So probably valid semver-patch.

Tasks:

@jfmengels
Copy link
Collaborator

I think we should probably separate submodule changelogs. Either by putting the core module's changelog first, then the resolvers (with a "table of contents" at the top of the page), or in separate files (I would choose option one). And it would be nice to have the same diff links ([1.8.1]) for the submodules.

Though we can do this all at a late time, and this LGTM ;)

@benmosher
Copy link
Member Author

Yeah, the resolvers have been kindof a pain in the changelog. Esp. because I can't create one of those diff links for a subtree (...right?).

I'd probably put them in their own file, but they have been changing somewhat infrequently so I haven't bothered. 😅

@jfmengels
Copy link
Collaborator

jfmengels commented May 23, 2016

I can't create one of those diff links for a subtree (...right?)

You could, if you prepend them with something like

## [resolvers/webpack-0.2.5] - 2016-05-23
[resolvers/webpack-0.2.5]: ./foo

jfmengels referenced this pull request May 23, 2016
* Added handling for multiple Webpack configs

If the Webpack config is an array, then use the first config that includes a resolve section.

* Adding unit test for multiple webpack configs

* Fixed unit test for multiple webpack configs

* Remove only call from unit test

* Added 'config-index' setting for resolving multiple configs

* Added documentation and release notes for multiple config support

* Fixed documentation for config-index; Fixed JSON in YAML examples
@benmosher benmosher merged commit edb57ce into master May 26, 2016
@benmosher benmosher deleted the release branch May 26, 2016 10:53
@jfmengels
Copy link
Collaborator

🎉

@benmosher
Copy link
Member Author

took long enough 😅

@benmosher benmosher restored the release branch June 1, 2016 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants