Adding handling for multiple Webpack configs #335
Conversation
If the Webpack config is an array, then use the first config that includes a resolve section.
|
I'm have a bear of a time trying to figure out how to configure |
|
Code looks great, strategy makes sense. Can you add a note about this new behavior in the resolver README and the root change log? As for installing from GitHub: not sure, since it's in a folder. |
|
Thanks! I'll add the note. I ended up getting it to work like this: "eslint-import-resolver-webpack": "file:node_modules/eslint-plugin-import/resolvers/webpack",
"eslint-plugin-import": "github:greengremlin/eslint-plugin-import#master-build", |
|
Done. I also added support for a |
|
The failure is a timeout in a test that does not cover my changes. |
| settings: | ||
| import/resolver: | ||
| webpack: { config: 'webpack.multiple.config.js' } | ||
| config-index: 1 |
There was a problem hiding this comment.
This actually needs to be a sibling of the "config" key, I think. The settings that the resolver gets are the contents of the object keyed by "webpack"
There was a problem hiding this comment.
Done. I also fixed the JSON piece in the YAML example.
|
Added docs look great, thanks! Just one note on the config-index example. And that test timeout thing is a real pain, I thought I had fixed it but apparently not. |
|
Done. I also fixed the mixed JSON / YAML in the documentation |
|
Is anything else needed to merge this? |
|
Nope, looks good! |
|
Great! Thanks. Any idea when you might push a release to npm? |
|
Likely by Friday evening. |
If the Webpack config is an array, then this change will use the first config that includes a resolve section.