Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: built-in automatic database backups #13773

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat: built-in automatic database backups #13773

merged 2 commits into from
Oct 31, 2024

Conversation

zackpollard
Copy link
Contributor

@zackpollard zackpollard commented Oct 28, 2024 •
edited
Loading

image

bo0tzz
bo0tzz reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realise it's still draft ;) Just a few stray thoughts

server/src/services/backup.service.ts Show resolved Hide resolved
server/src/services/backup.service.ts Show resolved Hide resolved
web/src/lib/components/admin-page/settings/backup-settings/backup-settings.svelte Outdated Show resolved Hide resolved
@zackpollard zackpollard force-pushed the feat/db-backups branch 9 times, most recently from 7789915 to be3f181 Compare October 29, 2024 13:14
jrasm91
jrasm91 reviewed Oct 29, 2024
View reviewed changes
server/src/config.ts Outdated Show resolved Hide resolved
server/src/main.ts Outdated Show resolved Hide resolved
server/src/services/backup.service.ts Show resolved Hide resolved
server/src/services/storage.service.ts Outdated Show resolved Hide resolved
@zackpollard zackpollard force-pushed the feat/db-backups branch 8 times, most recently from bf2ecb3 to ce7f408 Compare October 30, 2024 16:14
@zackpollard zackpollard marked this pull request as ready for review October 30, 2024 16:15
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 30, 2024
danieldietzler
danieldietzler reviewed Oct 30, 2024
View reviewed changes
server/src/dtos/system-config.dto.ts Show resolved Hide resolved
server/src/services/backup.service.spec.ts Outdated Show resolved Hide resolved
server/src/services/backup.service.spec.ts Outdated Show resolved Hide resolved
server/src/services/backup.service.spec.ts Outdated Show resolved Hide resolved
docs/docs/administration/backup-and-restore.md Outdated Show resolved Hide resolved
server/src/services/backup.service.ts Outdated Show resolved Hide resolved
server/src/services/backup.service.ts Outdated Show resolved Hide resolved
server/src/services/storage.service.spec.ts Outdated Show resolved Hide resolved
web/src/lib/components/admin-page/settings/backup-settings/backup-settings.svelte Outdated Show resolved Hide resolved
jrasm91
jrasm91 reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. Can you add screenshots?

server/src/repositories/storage.repository.ts Outdated Show resolved Hide resolved
server/src/services/backup.service.ts Outdated Show resolved Hide resolved
server/src/services/backup.service.ts Outdated Show resolved Hide resolved
danieldietzler
danieldietzler approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@zackpollard zackpollard merged commit 7d933ec into main Oct 31, 2024
36 checks passed
@zackpollard zackpollard deleted the feat/db-backups branch October 31, 2024 11:29
TimVanOnckelen pushed a commit to TimVanOnckelen/immich that referenced this pull request Nov 5, 2024
@zackpollard @TimVanOnckelen
feat: built-in automatic database backups (immich-app#13773)
890e6eb
@Scrumplex Scrumplex mentioned this pull request Nov 6, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo0tzz bo0tzz bo0tzz left review comments

@jrasm91 jrasm91 jrasm91 left review comments

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
changelog:feature documentation Improvements or additions to documentation 🗄️server 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zackpollard @jrasm91 @bo0tzz @danieldietzler