immich: 1.119.1 -> 1.120.1

[dotlambda]

Changelog:
https://github.com/immich-app/immich/releases/tag/v1.120.0
https://github.com/immich-app/immich/releases/tag/v1.120.1

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Scrumplex]

immich-app/immich#13773 added a regular database dump/backup job that utilizes pg_dumpall and gzip. I assume we need to add these to PATH using our existing wrapper.

[dotlambda]

Is there a way to start the backup manually so we can run it in the test?

[Scrumplex]

Is there a way to start the backup manually so we can run it in the test?

I think we should be able to trigger it using the following curl:

$ curl -X PUT --json '{"command": "start"}' "$baseUrl/api/jobs/backupDatabase"

And check for completion

$ curl "$baseUrl/api/jobs" | jq '.backupDatabase.jobCounts.completed > 0'

[teto]

dope ! I thought of suggesting a nixos module to backup immich this week (on the discussed nextcloud model) but this is too specific to be reusable properly. It was simpler to use the restic and postgresqlBackup module already. I might have to disable the latter if immich already does it !

[dotlambda]

Sounds like we're not supposed to use the built-in database backups: immich-app/immich#13971 (comment)

[emmertex]

This failed on build, I ran it a second time and it worked.
Not familiar with node to know why.

Installing dependencies
/nix/store/d7006iafqr1x3xi5saa2l5avpf156cin-npm-config-hook/nix-support/setup-hook: line 3:    98 Segmentation fault      (core dumped) npm ci --ignore-scripts $npmInstallFlags "${npmInstallFlagsArray[@]}" $npmFlags "${npmFlagsArray[@]}"

ERROR: npm failed to install dependencies

Here are a few things you can try, depending on the error:
1. Set `makeCacheWritable = true`
  Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
2. Set `npmFlags = [ "--legacy-peer-deps" ]`

error: builder for '/nix/store/igc7f3vm638g54x1ij3v6xslqf85v5rq-immich-1.120.1.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/4ybm2gg8xsdims9dxkisiakniakpb4cj-unit-immich-server.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/9dv50h6mxgn38pnzrc8bfpvs85g719xy-system-units.drv' failed to build
error: 1 dependencies of derivation '/nix/store/2ick4hn783rmm8dch1r4q1sxdkh710rg-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/jazbsxpyg9125cf1yn2ahiqh99nr7s4w-nixos-system-nixserver0-24.11.git.1df8bd30472f.drv' failed to build

[emmertex]

Adding perl back in as removed 1df8bd3
results in a good bulid and all working. I did not remove exiftool in this test, only re-added perl.

Nov 08 09:40:35 nixserver0 immich[1229]: [Nest] 1229  - 11/08/2024, 9:40:35 AM   ERROR [Api:ErrorInterceptor~e6tivfna] Unknown error: Error: Perl must be installed. Please add perl to your $PATH and try again.
Nov 08 09:40:35 nixserver0 immich[1229]: Error: Perl must be installed. Please add perl to your $PATH and try again.
Nov 08 09:40:35 nixserver0 immich[1229]:     at /nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/node_modules/exiftool-vendored/dist/ExifTool.js:106:15
Nov 08 09:40:35 nixserver0 immich[1229]:     at async /nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/node_modules/exiftool-vendored/dist/ExifTool.js:153:17
Nov 08 09:40:35 nixserver0 immich[1229]:     at async f (/nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/node_modules/exiftool-vendored/dist/ExifTool.js:401:13)
Nov 08 09:40:35 nixserver0 immich[1229]:     at async g (/nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/node_modules/exiftool-vendored/dist/AsyncRetry.js:8:20)
Nov 08 09:40:35 nixserver0 immich[1229]:     at async ServerInfoRepository.getBuildVersions (/nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/dist/repositories/server-info.repository.js:78:23)
Nov 08 09:40:35 nixserver0 immich[1229]:     at async ServerService.getAboutInfo (/nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/dist/services/server.service.js:36:31)
Nov 08 09:40:40 nixserver0 immich[1229]: [Nest] 1229  - 11/08/2024, 9:40:40 AM   ERROR [Api:ErrorInterceptor~bwday2jk] Unknown error: Error: Perl must be installed. Please add perl to your $PATH and try again.
Nov 08 09:40:40 nixserver0 immich[1229]: Error: Perl must be installed. Please add perl to your $PATH and try again.
Nov 08 09:40:40 nixserver0 immich[1229]:     at /nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/node_modules/exiftool-vendored/dist/ExifTool.js:106:15
Nov 08 09:40:40 nixserver0 immich[1229]:     at async /nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/node_modules/exiftool-vendored/dist/ExifTool.js:153:17
Nov 08 09:40:40 nixserver0 immich[1229]:     at async f (/nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/node_modules/exiftool-vendored/dist/ExifTool.js:401:13)
Nov 08 09:40:40 nixserver0 immich[1229]:     at async g (/nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/node_modules/exiftool-vendored/dist/AsyncRetry.js:8:20)
Nov 08 09:40:40 nixserver0 immich[1229]:     at async ServerInfoRepository.getBuildVersions (/nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/dist/repositories/server-info.repository.js:78:23)
Nov 08 09:40:40 nixserver0 immich[1229]:     at async ServerService.getAboutInfo (/nix/store/nd9h4qd4a1v0fwp610xkb6baw56vrlry-immich-1.120.1/dist/services/server.service.js:36:31)

diff --git a/pkgs/by-name/im/immich/package.nix b/pkgs/by-name/im/immich/package.nix
index 9562dc6301ed..81226591411c 100644
--- a/pkgs/by-name/im/immich/package.nix
+++ b/pkgs/by-name/im/immich/package.nix
@@ -24,6 +24,7 @@
   libraw,
   libheif,
   vips,
+  perl,
 }:
 let
   buildNpmPackage' = buildNpmPackage.override { inherit nodejs; };
@@ -209,6 +210,7 @@ buildNpmPackage' {
       --suffix PATH : "${
         lib.makeBinPath [
           exiftool
+          perl
           jellyfin-ffmpeg
         ]
       }"

[dotlambda]

Adding perl back in as removed 1df8bd3 results in a good bulid and all working.

I instead disabled the check whether perl is on the PATH.

[dotlambda]

I'll merge this today if nobody objects.
I also want to make people aware of immich-app/immich#14002.