Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update online DPDB URL #220

Merged
merged 4 commits into from
Apr 20, 2017
Merged

Update online DPDB URL #220

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb24adf
Update online DPDB URL
thoragio Apr 15, 2017
0a58380
Adjust URL to GitHub Pages
thoragio Apr 17, 2017
555d3c8
Adjust DPDB URL to point to WebVRRocks repo
thoragio Apr 19, 2017
a6e4d4a
Adjust DPDB URL to point to WebVRRocks subdomain
thoragio Apr 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/dpdb/dpdb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ var DPDB_CACHE = require('./dpdb-cache.js');
var Util = require('../util.js');

// Online DPDB URL.
var ONLINE_DPDB_URL = 'https://storage.googleapis.com/cardboard-dpdb/dpdb.json';
var ONLINE_DPDB_URL =
'https://thoragio.github.io/webvr-polyfill-dpdb/dpdb.json';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to transfer this to the WebVRRocks org, I'd be happy to help you maintain this as well. if you want to keep it on your GH Pages, that's quite all right too 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense to transfer it to WebVRRocks rather than keeping it in my own repo. Let me know how you want to go about that. Thanks.

Copy link
Contributor

@cvan cvan Apr 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you. Load https://github.com/thoragio/webvr-polyfill-dpdb/settings and scroll to the bottom and find the "Transfer ownership" section. When the modal form appears, enter webvr-polyfill-dpbdb and webvrrocks, respectively.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've done this just now. FYI, I got the following message upon screen reload: You don’t have the permission to create repositories on WebVRRocks.

Copy link
Contributor

@cvan cvan Apr 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invitation updated 👍 is it good now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. All done. GH Pages link is working: https://webvrrocks.github.io/webvr-polyfill-dpdb/dpdb.json

I'll update my PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks! 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gladly done!


/**
* Calculates device parameters based on the DPDB (Device Parameter Database).
Expand Down