Update online DPDB URL #220
Conversation
src/dpdb/dpdb.js
Outdated
| @@ -19,7 +19,8 @@ var DPDB_CACHE = require('./dpdb-cache.js'); | |||
| var Util = require('../util.js'); | |||
|
|
|||
| // Online DPDB URL. | |||
| var ONLINE_DPDB_URL = 'https://storage.googleapis.com/cardboard-dpdb/dpdb.json'; | |||
| var ONLINE_DPDB_URL = | |||
| 'https://rawgit.com/thoragio/webvr-polyfill-dpdb/master/dpdb.json'; | |||
There was a problem hiding this comment.
would you be able to publish the master branch of https://github.com/thoragio/webvr-polyfill-dpdb to GitHub Pages so it's served from https://thoragio.github.io/webvr-polyfill-dpdb? (the benefit is the caching is better on GitHub Pages than on RawGit.)
not absolutely necessary for this pass, but if you can easily do it, lmk. otherwise, we can probably still merge this (per @toji's approval).
There was a problem hiding this comment.
Sure, I have added a second commit that serves the file from GitHub Pages.
src/dpdb/dpdb.js
Outdated
| @@ -19,7 +19,8 @@ var DPDB_CACHE = require('./dpdb-cache.js'); | |||
| var Util = require('../util.js'); | |||
|
|
|||
| // Online DPDB URL. | |||
| var ONLINE_DPDB_URL = 'https://storage.googleapis.com/cardboard-dpdb/dpdb.json'; | |||
| var ONLINE_DPDB_URL = | |||
| 'https://thoragio.github.io/webvr-polyfill-dpdb/dpdb.json'; | |||
There was a problem hiding this comment.
if you want to transfer this to the WebVRRocks org, I'd be happy to help you maintain this as well. if you want to keep it on your GH Pages, that's quite all right too 😄
There was a problem hiding this comment.
I think it would make more sense to transfer it to WebVRRocks rather than keeping it in my own repo. Let me know how you want to go about that. Thanks.
There was a problem hiding this comment.
Great, thank you. Load https://github.com/thoragio/webvr-polyfill-dpdb/settings and scroll to the bottom and find the "Transfer ownership" section. When the modal form appears, enter webvr-polyfill-dpbdb and webvrrocks, respectively.
There was a problem hiding this comment.
OK, I've done this just now. FYI, I got the following message upon screen reload: You don’t have the permission to create repositories on WebVRRocks.
There was a problem hiding this comment.
invitation updated 👍 is it good now?
There was a problem hiding this comment.
OK. All done. GH Pages link is working: https://webvrrocks.github.io/webvr-polyfill-dpdb/dpdb.json
I'll update my PR.
src/dpdb/dpdb.js
Outdated
| @@ -19,7 +19,8 @@ var DPDB_CACHE = require('./dpdb-cache.js'); | |||
| var Util = require('../util.js'); | |||
|
|
|||
| // Online DPDB URL. | |||
| var ONLINE_DPDB_URL = 'https://storage.googleapis.com/cardboard-dpdb/dpdb.json'; | |||
| var ONLINE_DPDB_URL = | |||
| 'https://webvrrocks.github.io/webvr-polyfill-dpdb/dpdb.json'; | |||
There was a problem hiding this comment.
I just created a new subdomain for this, and apologies for asking for yet another change (!), could you change this URL to https://dpdb.webvr.rocks/dpdb.json?
There was a problem hiding this comment.
No problem. I've updated the PR.
Following on from the comment by @toji recently, I am resubmitting this PR to point to the DPDB cache I have been maintaining.
I'm happy to keep it updated and will watch this repo for any requests to add new devices to it.