Skip to content

add check for mapper_id and return unimplemtned on unsupported #32

add check for mapper_id and return unimplemtned on unsupported

add check for mapper_id and return unimplemtned on unsupported #32

GitHub Actions / clippy succeeded Apr 24, 2024 in 0s

clippy

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.79.0-nightly (244da22fa 2024-04-23)
  • cargo 1.79.0-nightly (80d5b607d 2024-04-19)
  • clippy 0.1.79 (244da22 2024-04-23)

Annotations

Check warning on line 5 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `debug`, `error`, `trace`, `warn`

warning: unused imports: `debug`, `error`, `trace`, `warn`
 --> src/main.rs:5:11
  |
5 | use log::{debug, error, info, trace, warn};
  |           ^^^^^  ^^^^^        ^^^^^  ^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 102 in src/lib/cartridge/cartridge.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant slicing of the whole range

warning: redundant slicing of the whole range
   --> src/lib/cartridge/cartridge.rs:102:22
    |
102 |             false => &bytestream[..],
    |                      ^^^^^^^^^^^^^^^ help: use the original value instead: `bytestream`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
    = note: `#[warn(clippy::redundant_slicing)]` on by default

Check warning on line 18 in src/lib/ppu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
  --> src/lib/ppu.rs:18:13
   |
18 | /// | 0x3F00          | Universal background color      |
   |             ^^^^ help: consider using four spaces per tab
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments
   = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default

Check warning on line 1 in src/lib/ppu.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `pixels::Pixels`

warning: unused import: `pixels::Pixels`
 --> src/lib/ppu.rs:1:5
  |
1 | use pixels::Pixels;
  |     ^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 5 in src/lib/opcodes/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary `pub(self)`

warning: unnecessary `pub(self)`
 --> src/lib/opcodes/mod.rs:5:1
  |
5 | pub(self) mod operations;
  | ^^^^^^^^^ help: remove it
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self

Check warning on line 80 in src/lib/cpu/addressing.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary `pub(self)`

warning: unnecessary `pub(self)`
  --> src/lib/cpu/addressing.rs:80:1
   |
80 | pub(self) mod fetching {
   | ^^^^^^^^^ help: remove it
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
   = note: `#[warn(clippy::needless_pub_self)]` on by default