add check for mapper_id and return unimplemtned on unsupported #32
imagine-hussainAnnotations
12 warnings
|
unused imports: `debug`, `error`, `trace`, `warn`:
src/main.rs#L5
warning: unused imports: `debug`, `error`, `trace`, `warn`
--> src/main.rs:5:11
|
5 | use log::{debug, error, info, trace, warn};
| ^^^^^ ^^^^^ ^^^^^ ^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
redundant slicing of the whole range:
src/lib/cartridge/cartridge.rs#L102
warning: redundant slicing of the whole range
--> src/lib/cartridge/cartridge.rs:102:22
|
102 | false => &bytestream[..],
| ^^^^^^^^^^^^^^^ help: use the original value instead: `bytestream`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
= note: `#[warn(clippy::redundant_slicing)]` on by default
|
|
using tabs in doc comments is not recommended:
src/lib/ppu.rs#L18
warning: using tabs in doc comments is not recommended
--> src/lib/ppu.rs:18:13
|
18 | /// | 0x3F00 | Universal background color |
| ^^^^ help: consider using four spaces per tab
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments
= note: `#[warn(clippy::tabs_in_doc_comments)]` on by default
|
|
unused import: `pixels::Pixels`:
src/lib/ppu.rs#L1
warning: unused import: `pixels::Pixels`
--> src/lib/ppu.rs:1:5
|
1 | use pixels::Pixels;
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unnecessary `pub(self)`:
src/lib/opcodes/mod.rs#L5
warning: unnecessary `pub(self)`
--> src/lib/opcodes/mod.rs:5:1
|
5 | pub(self) mod operations;
| ^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
|
|
unnecessary `pub(self)`:
src/lib/cpu/addressing.rs#L80
warning: unnecessary `pub(self)`
--> src/lib/cpu/addressing.rs:80:1
|
80 | pub(self) mod fetching {
| ^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: `#[warn(clippy::needless_pub_self)]` on by default
|
|
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|