Hacktober fest raje pr1 #226
Conversation
| /* | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2017-2022 Ilkka Seppälä |
There was a problem hiding this comment.
- Copyright (c) 2017-2024 Ilkka Seppälä
|
Changes LGTM ✅. Shall the copyright year be 2017-2024 or 2017-2022? |
|
I have done all the changes, the build is failing for a file which i have not changed or worked on |
Approved. Please squash the commits once. |
File Rename Snippet Code Snippet to Rename a File Test class for Code Snippet to Rename a File
rajeshsgr
force-pushed
the
hacktober-fest-raje-pr1
branch
from
d9441df
to
c443228
Compare
|
Squashed, please check |
|
This checks might be failing due to addition of main() in the code. I think only driver code is allowed to be pushed and not the main method. |
|
I have removed the main, it fails when it compiles - MultiArrayConcatenationSnippet.java and says it uses unchecked or unsafe operations. This is a file which i have not changed or worked on . |
I also faced many issues to get the scans successful. Not sure why MultiArrayConcatenationSnippet.java file compiled for me successfully. Is there any channel where we collaborators can connect? |
|
Also, could u plz review my PR #224? |
There was a problem hiding this comment.
Please check the following
- The build is failing
- README.md changes are missing (see https://github.com/iluwatar/30-seconds-of-java/blob/master/CONTRIBUTE.md)
Code Snippet for File Rename