Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LindenmayerSystemSnippet & tests and Update README.md #230

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

SayedQassim
Copy link
Contributor

@SayedQassim SayedQassim commented Oct 15, 2024

LindenmayerSystemSnippet.generateLindenmayerSystem(axiom, productionRules, 0)
);
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty/blank line at EOF to satisfy github.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ritabrata1080, Done.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @SayedQassim ✅.

please consider squashing multiple commits to maintain linear history on master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@Ritabrata1080 Ritabrata1080 Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iluwatar plz review this PR and also #224.

cc : @SayedQassim

Copy link

@Ritabrata1080 Ritabrata1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@iluwatar iluwatar merged commit a823656 into iluwatar:master Nov 3, 2024
1 check passed
@iluwatar
Copy link
Owner

iluwatar commented Nov 3, 2024

Looks good! Thank you for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants