Add ImagePullSecrets for Allocator and Ping (helm) (googleforgames#1190)

Added ImagePullSecrets, updated docs
ilkercelikyilmaz · Oct 23, 2020 · 5c6125f · 5c6125f
1 parent 517aaf2
commit 5c6125f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/install/helm/agones/templates/ping.yaml b/install/helm/agones/templates/ping.yaml
@@ -76,6 +76,10 @@ spec:
             value: {{ .Values.agones.ping.http.response | quote }}
           - name: UDP_RATE_LIMIT
             value: {{ .Values.agones.ping.udp.rateLimit | quote }}
+{{- if .Values.agones.image.controller.pullSecret }}
+      imagePullSecrets:
+        - name: {{.Values.agones.image.controller.pullSecret}}
+{{- end }}
   {{- if .Values.agones.ping.http.expose }}
 ---
 apiVersion: v1

diff --git a/install/helm/agones/templates/service/allocation.yaml b/install/helm/agones/templates/service/allocation.yaml
@@ -122,6 +122,10 @@ spec:
         - mountPath: /home/allocator/client-ca
           name: client-ca
           readOnly: true
+{{- if .Values.agones.image.controller.pullSecret }}
+      imagePullSecrets:
+        - name: {{.Values.agones.image.controller.pullSecret}}
+{{- end }}
 
 ---
 # Create a ClusterRole in that grants access to the agones allocation api

diff --git a/site/content/en/docs/Installation/helm.md b/site/content/en/docs/Installation/helm.md
@@ -117,7 +117,7 @@ The following tables lists the configurable parameters of the Agones chart and t
 | `agones.image.tag`                                  | Global image tag for all images                                                                 | `{{< release-version >}}` |
 | `agones.image.controller.name`                      | Image name for the controller                                                                   | `agones-controller`    |
 | `agones.image.controller.pullPolicy`                | Image pull policy for the controller                                                            | `IfNotPresent`         |
-| `agones.image.controller.pullSecret`                | Image pull secret for the controller                                                            | ``                     |
+| `agones.image.controller.pullSecret`                | Image pull secret for the controller, allocator, sdk and ping image. Should be created both in `agones-system` and `default` namespaces | ``                     |
 | `agones.image.sdk.name`                             | Image name for the sdk                                                                          | `agones-sdk`           |
 | `agones.image.sdk.cpuRequest`                       | The [cpu request][constraints] for sdk server container                                         | `30m`                  |
 | `agones.image.sdk.cpuLimit`                         | The [cpu limit][constraints] for the sdk server container                                       | `0` (none)             |