Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImagePullSecrets for Allocator and Ping (helm) #1190

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Nov 19, 2019

Added ImagePullSecrets, updated docs, tested with private registry.

Closes #1185 .

Added ImagePullSecrets, updated docs
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 38e65395-1d25-4410-bf3f-96a9b35803a8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1190/head:pr_1190 && git checkout pr_1190
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-41ae631

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit f0674b0 into googleforgames:master Nov 19, 2019
@aLekSer aLekSer deleted the ping-image-pull-secret branch November 19, 2019 20:47
@markmandel markmandel added this to the 1.2.0 milestone Dec 4, 2019
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Dec 4, 2019
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc kind/feature New features for Agones lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[helm] Missing imagePullSecrets Option in agones-ping Deployment
5 participants