fix(cosmosclient): use protobuf Any for TxMsgData
#2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2022 14:49
aljo242
requested review from
ilgooz,
lumtis,
jeronimoalbi,
tbruyelle and
fadeev
as code owners
|
Visit the preview URL for this PR (updated for commit 854f681): https://ignite-go-docs--pr2714-fix-proto-any-respon-ydrkbw6t.web.app (expires Tue, 16 Aug 2022 16:47:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Can confirm it solves Can run publish with both spn |
lumtis
approved these changes
Aug 9, 2022
ilgooz
approved these changes
Aug 9, 2022
Co-authored-by: Lucas Btd <[email protected]>
aljo242
pushed a commit
that referenced
this pull request
Aug 17, 2022
* docs(changelog): add unreleased section * feat!: Cosmos SDK v0.46.0 (#2675) * update go mod * update ibc path * fix merge errors * add temp client mock * fix: deps (#2676) * revert packages to old ibc-go * fix remaining ibc paths * fix template go.sum * panic keyring errors * add mockery generate instructions * regenerate mocks Co-authored-by: İlker G. Öztürk <[email protected]> * fix merge * update spn * upgrade spn * remove ibc-go fork * template updates * fix ibc and oracle templates * update templates * remaining tempalte updates * fix template * fix faucet test * use beta ibc release * update deps in template * use ibcmodule idiom (#2692) * Update ignite/templates/module/create/ibc/x/{{moduleName}}/module_ibc.go.plush Co-authored-by: Lucas Btd <[email protected]> * fix(`pkg/cosmosaccount`): register cryptocodec interfaces (#2702) * register crypto codec interfaces * improve error messages * fix(template): removed unused methods and fix comments (#2708) * fix(`cosmosclient`): use protobuf Any for TxMsgData (#2714) * fix comment * use proto Any * Update ignite/pkg/cosmosclient/cosmosclient.go Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Lucas Btd <[email protected]> * chore(0.46): upgrade spn version (#2730) * feat(`app`): add interchain accounts for `v0.46.0` (#2703) * update template for ica * Update ignite/templates/app/stargate/app/app.go.plush Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Lucas Btd <[email protected]> * fix: change relayer call to use secp256k1 private keys in call (#2729) This chage uses secp256k1 private keys instead of ASCII armored ones as gRPC arguments when calling the TS relayer. * docs: update tutorials (#2737) - Change `ibc-go` import to use "v5" - Add package missing definition to code examples that can be copy/pasted - Change file references to paths, for consistency with other tutorials - Fix interchange tutorial to use ports that don't overlap - Remove unused imports - Fix documentation issues * feat: upgrade `ts-relayer` dependencies (#2722) * chore: upgrade `@confio/relayer` to the latest version 0.5.1 * chore: update `@cosmjs` to version 0.28.9 * chore: remove `@cosmjs/launchpad` from dependencies * chore: add new dependency `@cosmjs/encoding` for relayer * chore: add `sinon` dependency required to build the relayer * fix: remove "gasLimit" option from relayer * fix: update `@cosmjs` to version 0.28.11 * fix(cosmosclient): fix account prefix config (#2743) * fix(cosmosclient): account prefix config not correct when broadcasting a tx from a newly created default account * add issue Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Denis Fadeev <[email protected]> Co-authored-by: Jerónimo Albi <[email protected]>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* docs(changelog): add unreleased section * feat!: Cosmos SDK v0.46.0 (ignite#2675) * update go mod * update ibc path * fix merge errors * add temp client mock * fix: deps (ignite#2676) * revert packages to old ibc-go * fix remaining ibc paths * fix template go.sum * panic keyring errors * add mockery generate instructions * regenerate mocks Co-authored-by: İlker G. Öztürk <[email protected]> * fix merge * update spn * upgrade spn * remove ibc-go fork * template updates * fix ibc and oracle templates * update templates * remaining tempalte updates * fix template * fix faucet test * use beta ibc release * update deps in template * use ibcmodule idiom (ignite#2692) * Update ignite/templates/module/create/ibc/x/{{moduleName}}/module_ibc.go.plush Co-authored-by: Lucas Btd <[email protected]> * fix(`pkg/cosmosaccount`): register cryptocodec interfaces (ignite#2702) * register crypto codec interfaces * improve error messages * fix(template): removed unused methods and fix comments (ignite#2708) * fix(`cosmosclient`): use protobuf Any for TxMsgData (ignite#2714) * fix comment * use proto Any * Update ignite/pkg/cosmosclient/cosmosclient.go Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Lucas Btd <[email protected]> * chore(0.46): upgrade spn version (ignite#2730) * feat(`app`): add interchain accounts for `v0.46.0` (ignite#2703) * update template for ica * Update ignite/templates/app/stargate/app/app.go.plush Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Lucas Btd <[email protected]> * fix: change relayer call to use secp256k1 private keys in call (ignite#2729) This chage uses secp256k1 private keys instead of ASCII armored ones as gRPC arguments when calling the TS relayer. * docs: update tutorials (ignite#2737) - Change `ibc-go` import to use "v5" - Add package missing definition to code examples that can be copy/pasted - Change file references to paths, for consistency with other tutorials - Fix interchange tutorial to use ports that don't overlap - Remove unused imports - Fix documentation issues * feat: upgrade `ts-relayer` dependencies (ignite#2722) * chore: upgrade `@confio/relayer` to the latest version 0.5.1 * chore: update `@cosmjs` to version 0.28.9 * chore: remove `@cosmjs/launchpad` from dependencies * chore: add new dependency `@cosmjs/encoding` for relayer * chore: add `sinon` dependency required to build the relayer * fix: remove "gasLimit" option from relayer * fix: update `@cosmjs` to version 0.28.11 * fix(cosmosclient): fix account prefix config (ignite#2743) * fix(cosmosclient): account prefix config not correct when broadcasting a tx from a newly created default account * add issue Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Denis Fadeev <[email protected]> Co-authored-by: Jerónimo Albi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves to using the
MsgResponsesfieldTxMsgDatainstead of the deprecatedMsgDatafield.This PR retains the decoding of deprecated messages in the
Decodemethod ofcosmosclient.