feat: upgrade Cosmos SDK to v0.46.0 and IBC to v5 #2677

ilgooz · 2022-07-29T07:56:39Z

No description provided.

* update go mod * update ibc path * fix merge errors * add temp client mock * fix: deps (#2676) * revert packages to old ibc-go * fix remaining ibc paths * fix template go.sum * panic keyring errors * add mockery generate instructions * regenerate mocks Co-authored-by: İlker G. Öztürk <[email protected]>

aljo242 · 2022-07-29T15:19:49Z

Not sure why it's failing now

EDIT: It was because of the added node commands - fixed

fadeev · 2022-08-03T13:01:43Z

wdyt about following the transfer module pattern and having a separate IBCModule type:

https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/ibc_module.go#L21-L30

and AppModuleBasic type:

https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/module.go#L33

This is how it could potentially look like:

https://github.com/fadeev/templateIBCv4/tree/master/x/foobar

aljo242 · 2022-08-03T13:15:51Z

wdyt about following the transfer module pattern and having a separate IBCModule type:

https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/ibc_module.go#L21-L30

and AppModuleBasic type:

https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/module.go#L33

This is how it could potentially look like:

https://github.com/fadeev/templateIBCv4/tree/master/x/foobar

Yeah, I like this pattern and it would be relatively easy to add !

* fix comment * use proto Any * Update ignite/pkg/cosmosclient/cosmosclient.go Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Lucas Btd <[email protected]>

github-actions · 2022-08-09T17:09:31Z

Visit the preview URL for this PR (updated for commit b1c9d12):

https://ignite-go-docs--pr2677-feat-sdk-ibc-upgrade-78213w5i.web.app

_{(expires Tue, 23 Aug 2022 13:32:55 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

* update template for ica * Update ignite/templates/app/stargate/app/app.go.plush Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Lucas Btd <[email protected]>

ignite/pkg/cosmosaccount/cosmosaccount.go

This chage uses secp256k1 private keys instead of ASCII armored ones as gRPC arguments when calling the TS relayer.

tbruyelle

I successfully ran the interchain tutorial with a CLI binary compiled with this branch, so LGTM!

- Change `ibc-go` import to use "v5" - Add package missing definition to code examples that can be copy/pasted - Change file references to paths, for consistency with other tutorials - Fix interchange tutorial to use ports that don't overlap - Remove unused imports - Fix documentation issues

* chore: upgrade `@confio/relayer` to the latest version 0.5.1 * chore: update `@cosmjs` to version 0.28.9 * chore: remove `@cosmjs/launchpad` from dependencies * chore: add new dependency `@cosmjs/encoding` for relayer * chore: add `sinon` dependency required to build the relayer * fix: remove "gasLimit" option from relayer * fix: update `@cosmjs` to version 0.28.11

* fix(cosmosclient): account prefix config not correct when broadcasting a tx from a newly created default account * add issue

aljo242 · 2022-08-16T13:30:39Z

Any remaining issues with this PR?

ilgooz · 2022-08-17T14:16:53Z

Great! Thanks everyone for making this happen!

@jeronimoalbi, @lubtd would you be able to give a review before we merge?

* docs(changelog): add unreleased section * feat!: Cosmos SDK v0.46.0 (ignite#2675) * update go mod * update ibc path * fix merge errors * add temp client mock * fix: deps (ignite#2676) * revert packages to old ibc-go * fix remaining ibc paths * fix template go.sum * panic keyring errors * add mockery generate instructions * regenerate mocks Co-authored-by: İlker G. Öztürk <[email protected]> * fix merge * update spn * upgrade spn * remove ibc-go fork * template updates * fix ibc and oracle templates * update templates * remaining tempalte updates * fix template * fix faucet test * use beta ibc release * update deps in template * use ibcmodule idiom (ignite#2692) * Update ignite/templates/module/create/ibc/x/{{moduleName}}/module_ibc.go.plush Co-authored-by: Lucas Btd <[email protected]> * fix(`pkg/cosmosaccount`): register cryptocodec interfaces (ignite#2702) * register crypto codec interfaces * improve error messages * fix(template): removed unused methods and fix comments (ignite#2708) * fix(`cosmosclient`): use protobuf Any for TxMsgData (ignite#2714) * fix comment * use proto Any * Update ignite/pkg/cosmosclient/cosmosclient.go Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Lucas Btd <[email protected]> * chore(0.46): upgrade spn version (ignite#2730) * feat(`app`): add interchain accounts for `v0.46.0` (ignite#2703) * update template for ica * Update ignite/templates/app/stargate/app/app.go.plush Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Lucas Btd <[email protected]> * fix: change relayer call to use secp256k1 private keys in call (ignite#2729) This chage uses secp256k1 private keys instead of ASCII armored ones as gRPC arguments when calling the TS relayer. * docs: update tutorials (ignite#2737) - Change `ibc-go` import to use "v5" - Add package missing definition to code examples that can be copy/pasted - Change file references to paths, for consistency with other tutorials - Fix interchange tutorial to use ports that don't overlap - Remove unused imports - Fix documentation issues * feat: upgrade `ts-relayer` dependencies (ignite#2722) * chore: upgrade `@confio/relayer` to the latest version 0.5.1 * chore: update `@cosmjs` to version 0.28.9 * chore: remove `@cosmjs/launchpad` from dependencies * chore: add new dependency `@cosmjs/encoding` for relayer * chore: add `sinon` dependency required to build the relayer * fix: remove "gasLimit" option from relayer * fix: update `@cosmjs` to version 0.28.11 * fix(cosmosclient): fix account prefix config (ignite#2743) * fix(cosmosclient): account prefix config not correct when broadcasting a tx from a newly created default account * add issue Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Denis Fadeev <[email protected]> Co-authored-by: Jerónimo Albi <[email protected]>

docs(changelog): add unreleased section

9f82e72

ilgooz requested a review from aljo242 as a code owner July 29, 2022 07:56

ilgooz changed the title ~~docs(changelog): add unreleased section~~ feat: upgrade Cosmos SDK to v0.46.0 and IBC to v5 Jul 29, 2022

ilgooz linked an issue Jul 29, 2022 that may be closed by this pull request

Cosmos SDK v0.46.0 upgrade tracking issue #2673

Closed

8 tasks

ilgooz mentioned this pull request Jul 29, 2022

Cosmos SDK v0.46.0 upgrade tracking issue #2673

Closed

8 tasks

ilgooz marked this pull request as draft July 29, 2022 08:03

ilgooz and others added 13 commits July 29, 2022 18:22

Merge branch 'develop' into feat/sdk-ibc-upgrade

f089110

fix merge

cb54554

Merge branch 'develop' into feat/sdk-ibc-upgrade

377d484

update spn

5724b7e

upgrade spn

9edc636

remove ibc-go fork

8d30121

template updates

a495f3d

fix ibc and oracle templates

6fe15bf

update templates

466124b

remaining tempalte updates

0e3c8e8

merge

72391f0

fix template

04875d7

fix faucet test

bb8dd9d

aljo242 marked this pull request as ready for review August 3, 2022 13:15

aljo242 requested review from lumtis, jeronimoalbi, tbruyelle and fadeev as code owners August 3, 2022 13:15

use beta ibc release

c388634

aljo242 self-assigned this Aug 3, 2022

Alex Johnson and others added 2 commits August 9, 2022 18:56

fix(cosmosclient): use protobuf Any for TxMsgData (#2714)

c64fe0d

* fix comment * use proto Any * Update ignite/pkg/cosmosclient/cosmosclient.go Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Lucas Btd <[email protected]>

Merge branch 'develop' into feat/sdk-ibc-upgrade

816b6ea

lumtis and others added 3 commits August 10, 2022 14:25

chore(0.46): upgrade spn version (#2730)

5da72db

feat(app): add interchain accounts for v0.46.0 (#2703)

d1a6819

* update template for ica * Update ignite/templates/app/stargate/app/app.go.plush Co-authored-by: Lucas Btd <[email protected]> Co-authored-by: Lucas Btd <[email protected]>

Merge branch 'develop' into feat/sdk-ibc-upgrade

fb6bec4

aljo242 added the priority/high label Aug 10, 2022

tbruyelle reviewed Aug 10, 2022

View reviewed changes

ignite/pkg/cosmosaccount/cosmosaccount.go Show resolved Hide resolved

tbruyelle reviewed Aug 10, 2022

View reviewed changes

ignite/pkg/cosmosaccount/cosmosaccount.go Show resolved Hide resolved

jeronimoalbi and others added 3 commits August 10, 2022 20:14

fix: change relayer call to use secp256k1 private keys in call (#2729)

70293c8

This chage uses secp256k1 private keys instead of ASCII armored ones as gRPC arguments when calling the TS relayer.

Merge branch 'develop' into feat/sdk-ibc-upgrade

9961ff2

Merge branch 'develop' into feat/sdk-ibc-upgrade

464621b

tbruyelle previously approved these changes Aug 12, 2022

View reviewed changes

jeronimoalbi dismissed tbruyelle’s stale review via 38ab4e0 August 12, 2022 11:30

tbruyelle previously approved these changes Aug 12, 2022

View reviewed changes

jeronimoalbi dismissed tbruyelle’s stale review via 0fa6a1e August 12, 2022 13:18

Alex Johnson and others added 2 commits August 12, 2022 09:31

Merge branch 'develop' into feat/sdk-ibc-upgrade

2e4b283

fix(cosmosclient): fix account prefix config (#2743)

b098f3a

* fix(cosmosclient): account prefix config not correct when broadcasting a tx from a newly created default account * add issue

tbruyelle approved these changes Aug 12, 2022

View reviewed changes

Alex Johnson added 2 commits August 15, 2022 10:38

Merge branch 'develop' into feat/sdk-ibc-upgrade

087641f

Merge branch 'develop' into feat/sdk-ibc-upgrade

b1c9d12

lumtis approved these changes Aug 17, 2022

View reviewed changes

aljo242 approved these changes Aug 17, 2022

View reviewed changes

aljo242 merged commit 693bf79 into develop Aug 17, 2022

aljo242 deleted the feat/sdk-ibc-upgrade branch August 17, 2022 15:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade Cosmos SDK to v0.46.0 and IBC to v5 #2677

feat: upgrade Cosmos SDK to v0.46.0 and IBC to v5 #2677

ilgooz commented Jul 29, 2022

aljo242 commented Jul 29, 2022 •

edited

Loading

fadeev commented Aug 3, 2022 •

edited

Loading

aljo242 commented Aug 3, 2022

github-actions bot commented Aug 9, 2022 •

edited

Loading

tbruyelle left a comment

aljo242 commented Aug 16, 2022

ilgooz commented Aug 17, 2022 •

edited

Loading

feat: upgrade Cosmos SDK to v0.46.0 and IBC to v5 #2677

feat: upgrade Cosmos SDK to v0.46.0 and IBC to v5 #2677

Conversation

ilgooz commented Jul 29, 2022

aljo242 commented Jul 29, 2022 • edited Loading

fadeev commented Aug 3, 2022 • edited Loading

aljo242 commented Aug 3, 2022

github-actions bot commented Aug 9, 2022 • edited Loading

tbruyelle left a comment

Choose a reason for hiding this comment

aljo242 commented Aug 16, 2022

ilgooz commented Aug 17, 2022 • edited Loading

aljo242 commented Jul 29, 2022 •

edited

Loading

fadeev commented Aug 3, 2022 •

edited

Loading

github-actions bot commented Aug 9, 2022 •

edited

Loading

ilgooz commented Aug 17, 2022 •

edited

Loading