Fix tomcat_version variable usage #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the "Download & Extract Tomcat" task we try to detect if the tomcat
version to install is the same as the configured in the variables.
The check used the literal `tomcat_version` instead of
interpolating the Jinja2 value like `{{ tomcat_version }}`.
agimenez
changed the title
|
OK, "draft" is not what I thought. Setting to Ready for review but adding WIP to the title. |
|
Hi @agimenez thanks for noticing this missbehaviour, I've verified the mentioned issues. |
We were executing the download and extract task if the currently installed version was the same as the wanted one. This fixes the condition, and only executes the task if versions are different, as intended.
|
@vicsufer branch updated with the comparison fix. Thanks! |
vicsufer
requested changes
Mar 29, 2021
agimenez
changed the title
jperera
approved these changes
Mar 30, 2021
emepege
approved these changes
Mar 30, 2021
blalop
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In the "Download & Extract Tomcat" task we try to detect if the tomcat
version to install is the same as the configured in the variables.
The check used the literal
tomcat_versioninstead ofinterpolating the Jinja2 value like
{{ tomcat_version }}.NOTE: this opens a new changelog "Fixed" section as well as #96. I will set this as draft as it would cause conflicts on merge. If the other PR is merged in, I will rebase this branch against the latest develop to avoid conflicts.
Benefits
The check that tries to figure out whether the installed Tomcat is the wanted version in the
tomcat_versionvariable should work as expected.Possible Drawbacks
TBH, I'm not sure how this was working before. I guess that the particular version check was yelding
falsealways.Also, if I understand correctly, the check should be
!=instead of==, since I believe that this task will download & install if the installed version is different from the one we want. Is that right? In such case, I can fix the conditional as well.Applicable Issues
N/A