Fix check_mode for Tomcat Version Check #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the Ansible in check mode, the task "Download & Extract
Tomcat" fails because the `tomcat_check` variable is not defined.
The cause is that when Ansible runs in check mode, tasks with the
'command' module are not executed. The Tomcat Version check task
executes a java command that registers the `tomcat_check` variable,
which is used in the next task ("Download & Extract Tomcat").
As the command is not executed, the variable does not exist and the
conditional test fails.
Forcing the execution of the command, even in check mode, makes the
variable to be defined and the checks to be successful.
sorobon
requested review from
blalop,
caldito,
dortegau,
frantsao,
jmonterrubio,
jperera,
vicsufer and
xtianae7
blalop
approved these changes
Mar 16, 2021
frantsao
approved these changes
Mar 16, 2021
|
Hey, I can see that a check has failed. Not sure if it has something to do with these changes? |
vicsufer
approved these changes
Mar 17, 2021
re-running the job that failed, fixed the check :) LGTM |
xtianae7
approved these changes
Mar 17, 2021
caldito
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
When running the Ansible in check mode, the task "Download & Extract
Tomcat" fails because the
tomcat_checkvariable is not defined.The cause is that when Ansible runs in check mode, tasks with the
'command' module are not executed. The Tomcat Version check task
executes a java command that registers the
tomcat_checkvariable,which is used in the next task ("Download & Extract Tomcat").
As the command is not executed, the variable does not exist and the
conditional test fails.
Forcing the execution of the command, even in check mode, makes the
variable to be defined and the checks to be successful.
Benefits
Role does not fail in Ansible check mode
Possible Drawbacks
Other tasks may have the same problem (I haven't checked).
Applicable Issues
N/A