-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify AD headers and remove DualReal from the repo #27582
Conversation
Job Precheck on 5d2d3ed wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
8cd08f8
to
f86e7b5
Compare
Job Precheck on f86e7b5 wanted to post the following: A change of the following file(s) triggered this check: libmesh The following file(s) are unchanged: conda/mpich/conda_build_config.yaml The libmesh submodule or configuration was changed but the conda build config was not |
599b758
to
0bfc54e
Compare
Job Documentation on abe1513 wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage on abe1513 wanted to post the following: Framework coverage
Modules coverageFluid properties
Geochemistry
Navier stokes
Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
Job Clang min debug on 0bfc54e : invalidated by @lindsayad |
Forward compatibility with idaholab/moose#27582
Forward compatibility with idaholab/moose#27582
Wasnt DualReal meant to more efficient? But was it? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost done no comment so far
Forward compatibility with idaholab/moose#27582
Job Internal app tests on abe1513 : invalidated by @lindsayad |
Job Documentation internal apps on abe1513 : invalidated by @lindsayad |
Inspired by development in #27529
Reason
The AD headers were a labyrinth
Design
Consolidate the headers and also remove all occurrences of
DualReal
in favor ofADReal
Impact
Easier to follow AD headers