Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify AD headers and remove DualReal from the repo #27582

Merged
merged 1 commit into from
May 13, 2024

Conversation

lindsayad
Copy link
Member

Inspired by development in #27529

Reason

The AD headers were a labyrinth

Design

Consolidate the headers and also remove all occurrences of DualReal in favor of ADReal

Impact

Easier to follow AD headers

@moosebuild
Copy link
Contributor

Job Precheck on 5d2d3ed wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/27582/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 82d4457f6b164d77d42bd5a43425397e6fbc49c3

@lindsayad lindsayad force-pushed the dualreal-adreal branch 3 times, most recently from 8cd08f8 to f86e7b5 Compare May 8, 2024 22:03
libmesh Outdated Show resolved Hide resolved
@moosebuild
Copy link
Contributor

Job Precheck on f86e7b5 wanted to post the following:

A change of the following file(s) triggered this check:

libmesh

The following file(s) are unchanged:

conda/mpich/conda_build_config.yaml
conda/libmesh/meta.yaml

The libmesh submodule or configuration was changed but the conda build config was not

@lindsayad lindsayad force-pushed the dualreal-adreal branch 2 times, most recently from 599b758 to 0bfc54e Compare May 8, 2024 23:10
@moosebuild
Copy link
Contributor

moosebuild commented May 9, 2024

Job Documentation on abe1513 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented May 9, 2024

Job Coverage on abe1513 wanted to post the following:

Framework coverage

639315 #27582 abe151
Total Total +/- New
Rate 85.08% 85.08% -0.00% 31.15%
Hits 103065 103062 -3 19
Misses 18069 18070 +1 42

Diff coverage report

Full coverage report

Modules coverage

Fluid properties

639315 #27582 abe151
Total Total +/- New
Rate 85.47% 85.47% - 66.07%
Hits 7261 7261 - 74
Misses 1234 1234 - 38

Diff coverage report

Full coverage report

Geochemistry

639315 #27582 abe151
Total Total +/- New
Rate 96.18% 96.18% - 100.00%
Hits 5155 5155 - 1
Misses 205 205 - 0

Diff coverage report

Full coverage report

Navier stokes

639315 #27582 abe151
Total Total +/- New
Rate 83.87% 83.87% - 100.00%
Hits 15983 15983 - 1
Misses 3073 3073 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 31.15% is less than the suggested 90.0%
  • fluid_properties new line coverage rate 66.07% is less than the suggested 90.0%

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Clang min debug on 0bfc54e : invalidated by @lindsayad

lindsayad added a commit to lindsayad/magpie that referenced this pull request May 9, 2024
Forward compatibility with idaholab/moose#27582
lindsayad added a commit to lindsayad/raccoon that referenced this pull request May 9, 2024
Forward compatibility with idaholab/moose#27582
@GiudGiud
Copy link
Contributor

GiudGiud commented May 9, 2024

Wasnt DualReal meant to more efficient? But was it?

@lindsayad
Copy link
Member Author

ADReal and DualReal were the exact same types

Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done no comment so far

hugary1995 pushed a commit to hugary1995/raccoon that referenced this pull request May 11, 2024
@moosebuild
Copy link
Contributor

Job Internal app tests on abe1513 : invalidated by @lindsayad

@moosebuild
Copy link
Contributor

Job Documentation internal apps on abe1513 : invalidated by @lindsayad

@lindsayad lindsayad merged commit d76ac1a into idaholab:next May 13, 2024
47 checks passed
@lindsayad lindsayad deleted the dualreal-adreal branch May 13, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants